media_gallery_view() destroys $node->media_gallery_media

Closing this issue, because it seems to be fixed with beta7

sorry, too soon, I was looking at a cached version.

Updated patch for beta7

I've attached an export of the random images view I've created (view.php.gz).

This issue has not been resolved. Let me specify the issue:

I have a view (see album_list.view.php in the attached tar.gz) which generates a page of the teasers of all my albums. I also have a view (see random_images.view.php) which generates a block with 5 random images from albums new than 3 years, this block is displayed on all pages.

When media_gallery displays a teaser of an album-node, it destroys the $node->media_gallery_media array (see media_gallery.module:279):

  // For the teaser, only the first thumbnail needs to be displayed, so remove the
  // rest from the node's field data, so that the field formatter doesn't waste
  // time building the render structure for items that won't be shown.
  if ($view_mode == 'teaser') {
    if (!empty($node->media_gallery_media[LANGUAGE_NONE])) {
      $first_item = array_shift($node->media_gallery_media[LANGUAGE_NONE]);
      $node->media_gallery_media[LANGUAGE_NONE] = array($first_item);
    }
  }

It does not restore the array later on and drupal caches the node with the broken media_gallery_media array. So when the view that generates the block with random images is being run, it will use the database to find the images, but the rendering code can't find the image in the media_gallery_media array and will generate an img-tag with empty src-attribute.

The solution for this is to restore the media_gallery_media array in a hook that is called after media_gallery_view() (see the patch attached to this issue).