Problem/Motivation

Actually when we configure a bundle "Image" during the create process we have to add field_image to be automatically recover but configuration aren't updated and when we try to upload an image a notice appear because $source_field is empty and code does not support/prevent this case.

Proposed resolution

Prevent this case and refactor smally file recovery to use Refactor method "Extract Method" to increase readability in code.

CommentFileSizeAuthor
#2 fixe_notice_thumbnail-2923293-2.patch6.08 KBwoprrr
Capture d’écran 2017-11-14 à 10.34.06.png1.14 MBwoprrr
Capture d’écran 2017-11-13 à 23.30.46.png513.56 KBwoprrr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

woprrr created an issue. See original summary.

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and commented
Status: Active » Needs review
FileSize
fixe_notice_thumbnail-2923293-2.patch6.08 KB

This patch solve this notice and fixe five coding standard miss.

Status: Needs review » Needs work

The last submitted patch, 2: fixe_notice_thumbnail-2923293-2.patch, failed testing. View results

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and commented
Status: Needs work » Needs review

Tests fail before this issue caused by media_entity route enhancer deprecated usage.