Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Just an small issue to fixe a little problems of standards.
Code sniffer tell :
FILE: ...er_template/web/modules/contrib/media_entity_image/DEVELOPING.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 92 characters
----------------------------------------------------------------------
FILE: ...web/modules/contrib/media_entity_image/media_entity_image.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...mposer_template/web/modules/contrib/media_entity_image/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
40 | WARNING | Line exceeds 80 characters; contains 110 characters
----------------------------------------------------------------------
FILE: ...ib/media_entity_image/src/Plugin/EntityBrowser/Widget/Upload.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
82 | ERROR | [x] Opening brace must be the last content on the line
82 | ERROR | [x] There should be no white space after an opening "{"
82 | ERROR | [x] There should be no white space before a closing "}"
82 | ERROR | [x] Closing brace must be on a line by itself
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...contrib/media_entity_image/src/Plugin/MediaEntity/Type/Image.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
29 | ERROR | [x] Expected "\Drupal\Core\Image\ImageFactory" but
| | found "\Drupal\Core\Image\ImageFactory;" for @var
| | tag in member variable comment
36 | ERROR | [x] Expected "array" but found "array." for @var tag in
| | member variable comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Proposed resolution
Fixe all warnings.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 612 bytes | slashrsm |
#3 | 2853878_3.patch | 5.58 KB | slashrsm |
#2 | small_fixes_coding-2853878-2.patch | 5.49 KB | woprrr |
Comments
Comment #2
woprrr CreditAttribution: woprrr at NeoLynk commentedComment #3
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedA minor improvement.
Comment #5
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedCommitted.