The following issues are reported on phpcs:


FILE: ...al-8.4.3/modules/media_entity_flickr/media_entity_flickr.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 39 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing
    |       |     parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...3/modules/media_entity_flickr/src/Plugin/media/Source/Flickr.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 171 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, colons, question marks, or
     |       |     closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
CommentFileSizeAuthor
#5 patch works.PNG8.33 KBragasirtahk
#4 Screenshot from 2018-01-17 13-28-19.png22.94 KBjeetendrakumar
#2 code_review_changes-2936324-2.patch1.19 KBvenkatesh rajan.j

Comments

Venkatesh Rajan.J created an issue. See original summary.

venkatesh rajan.j’s picture

venkatesh rajan.j commented
Status: Active » Needs review
StatusFileSize
new code_review_changes-2936324-2.patch1.19 KB

The attached patch will fix the reported errors.

ragasirtahk’s picture

ragasirtahk commented
Status: Needs review » Reviewed & tested by the community

Seems good now.

jeetendrakumar’s picture

jeetendrakumar commented
StatusFileSize
new Screenshot from 2018-01-17 13-28-19.png22.94 KB

Patch is working fine.

ragasirtahk’s picture

ragasirtahk commented
StatusFileSize
new patch works.PNG8.33 KB

Patch is fine. Ready for commit.