In the course of working on some other issues, I've spotted a few English language errors in the text strings and Doxygen comments. I've gone through all of the module and tried to make the changes consistent. There are a couple of spelling corrections, one conversion from British to American English ('ticked' => 'checked'), plenty of "it's" [it is] => "its" [possessive form of it], lots of removal of the comma before 'that', but one change of ', that' into ', which'. Some allowed me to change the number of lines that a comment is spread over. And two of them (one sentence, repeated once) I can't fix because I don't know what it is supposed to say, so I've commented them 'FIXME'.

Patch attached to comment #1.

CommentFileSizeAuthor
#2 media_derivatives.code_.2118759-2.patch24.21 KBmartin_q
#1 media_derivatives.code_.2118759-1.patch23.46 KBmartin_q
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
CreditAttribution: martin_q commented
Status: Active » Needs review
FileSize
media_derivatives.code_.2118759-1.patch23.46 KB

Patch with proposed corrections.

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
CreditAttribution: martin_q commented
FileSize
media_derivatives.code_.2118759-2.patch24.21 KB

Patch re-rolled with one more item (sorry).

By the way, there is still more work to be done to ensure that all of the Doxygen comments are correctly formatted, but I didn't attempt all that at this time.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Active

Thank you! Great job! Committed.

http://drupalcode.org/project/media_derivatives.git/commit/c856867

I'll leave this open as there is still work to do.

ahoeben’s picture

ahoeben CreditAttribution: ahoeben commented

How about "Select fields for which derivative creation events should be fired" for the FIXME line?
Or simply "Select fields to create derivatives for"?

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
CreditAttribution: martin_q commented

*lightbulb* Suddenly it makes perfect sense. Yes, that is what I now think the original description meant, and I'm happy with either of those. The shorter version is also in plainer English, which is obviously better.