Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There have been some changes made in the function that is stored in variable create_element in media_wysiwyg.filter.js.
Where as previously the function did "Serializes file information as a url-encoded JSON object", now the function is not serializing and url encoding anymore. Therefore I would propose to change the description in the inline code documentation.
I provided a small patch.
Beside storing file information as a data attribute on the html element there are some other things done which I loosely described as "doing fancy stuff" in order not to bloat the documentation and also because I am not sure about everything that is done here.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | Reflect_changes_in_JS_function_in_the_inline_documentation-2879857-2.patch | 778 bytes | stefan.korn |
Comments
Comment #2
stefan.kornComment #3
joseph.olstadyes the code comments for that should most likely be updated.
However, the wording would be more like:
The client sends a list of safe parameters in the url, the server stores that into a variable cache returns a response with a hash key which is used to retrieve a session variable (array) containing the required information that is session specific. No one other than that user will have that hash key , this safeguards the back end by locking down only to the whitelisted params. The tradeoff is you have to make sure that everything interfacing with media plays nice and that if there are new safe params , they must be added to the whitelist for them to work. Something like this? unless I'm looking at the wrong section of javascript code.
Comment #4
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedRecent versions of media have resolved most of peoples concerns and is compatible with entity translation, multilingual and various advanced configurations. Due to the high volume of inactive and most often irrelevant issues we are Closing this as (outdated). If for whatever reason this issue is important to you AND you still have issues after checking the media recipe documentation, then let us know and we will review your concerns.
Otherwise, see the recipe documentation for how to configure media and for troubleshooting tips OR refer to the media_dev distribution if you want to see a working media setup.
As mentioned, feel free to make some noise in this issue if you still feel it is important to you or someone else.
Thanks,
Media team