Thanks to all who worked on issue 951004 (especially @mglaman). Now multiple files can be uploaded at once! The files however appear in reverse order on the Node Edit Form. There was some discussion about this in issue 951004 (see #118, #136, #204, #205), but I'm not sure what was decided. So much work was put into this, this small matter may need its own issue.

CommentFileSizeAuthor
#6 media-multiselect-fix-order-2834464-6.patch1.34 KBann b
#3 media-multiselect-fix-order-2834464-1.patch1.53 KBann b
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ann b created an issue. See original summary.

ann b’s picture

ann b CreditAttribution: ann b commented
Version: 7.x-2.0-beta13 » 7.x-2.x-dev
Status: Active » Needs review

Patch #3 is actually code from the #205 patch of the Allow selecting of multiple media items for a multi value media field in the same dialog issue. So many thanks to @gregori.goossens, @jsst and @uniquename.

ann b’s picture

ann b CreditAttribution: ann b commented
FileSize
media-multiselect-fix-order-2834464-1.patch1.53 KB

Status: Needs review » Needs work

The last submitted patch, 3: media-multiselect-fix-order-2834464-1.patch, failed testing.

ann b’s picture

ann b CreditAttribution: ann b commented

Patch was created incorrectly.

ann b’s picture

ann b CreditAttribution: ann b commented
FileSize
media-multiselect-fix-order-2834464-6.patch1.34 KB
ann b’s picture

ann b CreditAttribution: ann b commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Thanks! Any reviewers?

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

It would be nice to get this into the next release candidate at some point. I'm willing to put it in dev, if there's a problem afterwards, we can always revert.

ann b’s picture

ann b CreditAttribution: ann b commented

Thank you Joseph. The code change is minor, and I did test the patch before uploading it. Adding it to dev shouldn't cause a problem. I also sent a PM to the developers who created the original patch, in case they wanted to help with the review.

  • joseph.olstad committed e8eb54c on 7.x-2.x authored by ann b 
    Issue #2834464 by ann b: Multiple Files Attached in Reverse Order
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Fixed

It is committed to 7.x-2.x dev. If there's no reported problems between now and the next release, it will make it into 7.x-2.0-rc2

Thanks very much!

ann b’s picture

ann b CreditAttribution: ann b commented

Thank you Joseph!

jsst’s picture

jsst CreditAttribution: jsst at Ibuildings commented

Thanks for the perseverance on this issue Ann!

For what it's worth, the solution that landed in 7.x-2.x is the right one: I've seen patch #205 (in the other thread) being used in production for more than a year. The mistake was merging patch #219 which was based on #197 (which was confirmed broken) instead of #205 (where we fixed the ordering issue by explicitly setting the weight on each file upload and reversing the items client-side).

ann b’s picture

ann b CreditAttribution: ann b commented

You're welcome @jsst! And thank you for providing the code and taking the time to review the new patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.