CKEditor Strips out Picture Tags When Inserting Images of Picture Type

same here, have you found a solution?

Hi, I just turned off ckeditors Advanced content filter. Now all picture markup inserted remains.

I had to use this workaround to make Media WYSIWYG and CKEditor (part of WYSIWYG) work together:

/**
 * Implements hook_file_displays_alter().
 */
function YOUR_MODULE_file_displays_alter(&$displays, $file, $view_mode) {
  // Disable Picture display in WYSIWYG mode. Normal <img> will be rendered
  // instead. CKEditor and Media WYSIWYG modules with render with common <img>
  // while frontend will render full <picture> output as usual.
  if (!empty($file->override['wysiwyg']) && !empty($displays['file_field_picture']['status'])) {
    $displays['file_field_picture']['status'] = 0;
  }
}

It simply doesn't render <picture> at all in WYSIWYG mode. Fallback display will be used to render image (see attached).

I quickly ran though the code in Chrome and my current assumption is that `media_wysiwyg.filter.js` can't properly parse and replace <picture> output.

Interesting, where is this 'picture' type comming from? is this a custom module making this type? or is this a type of image that you created?

Oh ok, nevermind, I see issue summary now, picture is a module. I haven't tried this module before.

this code could either go into the media module as a patch, or into the picture module as a patch or commit.
have to make a patch

Please back off your custom workaround(s) and try this patch , should apply to either 7.x-3.x or 7.x-2.x.

for those using the media_ckeditor module, we may have to make a patch for that too. But in the media_ckeditor queue.

I'm tempted to mark as RTBC, but technically I can't say patch #11 works for Media WYSIWYG, since I'm using Media CKEditor.

However, I used your patch to create a Media CKEditor version. Works perfectly: https://www.drupal.org/project/media_ckeditor/issues/2938748

Given there is a lot of overlap, maybe we can get both of these versions to RTBC?

Hi ron_s , so patch 11 works for you when using media_ckeditor?

If it doesn't , set this issue back to 'Needs review'

to be extra careful could write an if module_exists

if (module_exists('picture')) {
  // add magic juice seen in patch 11
}

I think the module_exists is an excellent idea.

Here's an update with the suggestion. Works for me.

Also in case it wasn't clear, this can be set to RTBC. Thanks!

Thanks @ron_s and everyone else!
committed to 7.x-2.x dev and 7.x-3.x dev
will make it into next release whenever that is.