The media browser currently hides the jQuery UI dialog title and close button. After a recent UI review by lea.refice, it was found that users expected a close button as seen in most lightboxes and the core overlay module. It was also found that the default "Select a file" title can be confusing if users are only able to upload a new file.

It was suggested that unhiding the dialog header and leaving the title and close button would be preferred. Themes are also required to include their own jQuery UI styling, so no additional styling changes should be necessary.

CommentFileSizeAuthor
#1 display-title-and-close-button-2182823-1.patch11.02 KBDevin Carlson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
FileSize
display-title-and-close-button-2182823-1.patch11.02 KB

A patch to replace the form title with a dialog title and the fake-cancel buttons with a close button.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Needs review » Fixed

Retested #1 on a few existing sites with Media installed and confirmed that the dialog title and close button was displayed and that the fake cancel buttons were removed.

The dialog title was styled plain-at-worst on most themes and looked great on theme's that included their own jQuery UI CSS. The removal of $output['title'] generally feed up a lot of vertical space and helped with confusion when only tabs such as "upload" or "web" were enabled.

Committed #1 to Media 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gettysburger’s picture

gettysburger CreditAttribution: gettysburger commented

I upgraded to Media 7.x-2.0-beta1 and when I go to upload an image I still do not see a title.

The code looks like this:

<span id="ui-id-1" class="ui-dialog-title">&nbsp;</span>

Am I missing something? Thanks.

eelkeblok’s picture

eelkeblok
him/his
Primary language Dutch
Location Netherlands 🇳🇱
CreditAttribution: eelkeblok at One Shoe commented

FWIW, I find that some users actually expect the Cancel button. Would it make sense to restore that in addition to the close button?

chicagomom’s picture

chicagomom CreditAttribution: chicagomom as a volunteer commented

Understand the cancel button removal, but I propose that the dialog title be re-added. Without it, there is no orientation/instructional content for the user. It's non-normative and as another poster mentioned, is a usability issue.

I propose re-adding these:

    $output['title'] = array(
    '#markup' => t('Select a file')
  );