Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After this got in #1553114: Adding files should be a multi-step process now there is no need to have the edit modal form
Comment | File | Size | Author |
---|---|---|---|
#1 | media-remove_edit_modal_after_upload-1848034-1.patch | 2.96 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedComment #2
arthurf CreditAttribution: arthurf commentedTested this with new and existing media and seems to work correctly. Nice to see another file get removed!
Is the next logical issue to address the ctools modal for a file field edit?
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedwhat do you mean with address?
Comment #4
Dave ReidI'm not sure what we can do with the 'Edit' button yet?
Comment #5
arthurf CreditAttribution: arthurf commentedI think it's strange that we have two different styles of interfaces for dealing with files- ctools modal and the media modal. It's beyond the scope of this issue so I'll hush up for now.
Comment #6
Dave ReidYeah I guess we could open an issue to use our custom modal with the Edit file button, but the hope was to reduce code we have to maintain. I think a better issue would be to style the ctools modal to "look" like our custom modal for now (as a separate issue).
Comment #7
ParisLiakos CreditAttribution: ParisLiakos commentedi went ahead and committed #1 since this is quite a usability improvement
http://drupalcode.org/project/media.git/commit/156399b
Comment #9
gmclelland CreditAttribution: gmclelland commentedDid anyone open up a followup issue as per @Dave Reid's suggestions in #6 to style the ctools modal dialog to look like media module's modal dialog?