Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The following patch is a direct backport of the work I am doing with Drupal 8 found here http://drupal.org/node/1174892.
I would like for the Media module to be the official D7 backport of this work if you guys are willing. If we take this, then I can officially deprecate the http://drupal.org/project/html5_media module, which would be sweet.
Patch to follow.
Comment | File | Size | Author |
---|---|---|---|
#2 | media-video_audio_support-1496528-2.patch | 369.36 KB | travist |
Comments
Comment #1
Dave ReidAwesome. I know for sure we at least want to have
<audio>
and<video>
native tag support in Media. Maybe we add some simple support first but then I would love for us to be able to support a fully-featured player included in Media. It makes total sense to do.Comment #2
travist CreditAttribution: travist commentedHere is a visual diff of this patch: https://github.com/travist/drupal-media-module/compare/7.x-2.x...7.x-2.x...
Comment #3
travist CreditAttribution: travist commentedComment #4
dmurkerson CreditAttribution: dmurkerson commentedHello:
I've just tried to apply this patch to the 2.0 dev version of the Media module on my Drupal 7 site according to these instructions: http://drupal.org/patch/apply and I'm getting "Hunk Failed" errors.
I'm trying to incorporate the Media module into Wysiwyg so that I can upload media files and have them display in a player on my site. This patch was listed on the Media main project page as an update to be able to do this.
Any help would be appreciated.
Thanks,
Danielle
Comment #5
tsvenson CreditAttribution: tsvenson commented@dmurkerson: Hunk failed means that the patch couldn't be applied cleanly. This usually is due to that since the patch was created, a lot of other code has been committed to the project, casing this patch the be "out-of-sync" so to speak.
To fix it you need to manually apply the patch. Alternatively wait until someone re-rolls the patch against a current checkout of the code.
Comment #6
dmurkerson CreditAttribution: dmurkerson commentedYes, that is why I commented on this. I began to apply it manually (I'm no stranger to code) however, since there were so many files this patch was fixing/creating I thought it best to use the patch functionality in Linux to do it for me so that there would be less chance I'd miss something in applying it manually.
I'll keep watch here and elsewhere as well as apply it myself again and see if that helps.
Thanks.
Comment #7
travist CreditAttribution: travist commentedI will work on getting an updated patch and player.
Comment #8
dddave CreditAttribution: dddave commentedjfyi I linked to this issue in http://groups.drupal.org/node/233238
Comment #9
pschuelke CreditAttribution: pschuelke commentedThe patch does indeed have hunk errors when applying.
I just tried to do a manual install of the #2 patch with 2.x dev. It doesn't seem to like to play with the most recent changes.
Comment #10
pschuelke CreditAttribution: pschuelke commentedThere is a patch that does this here.
Comment #11
Devin Carlson CreditAttribution: Devin Carlson commentedAs mentioned in #10, this issue belongs to file entity.
#1748952: Add simple HTML5 file field formatters for <audio> and <video>