Countdown not working for ckeditor5

Hello @cedewey

The issue I see here is that the plugin "Character Count Plugin - jQuery plugin" provided by the module says:

"Dynamic character count for text areas and input fields"...

What do we have is:
1. A hidden textarea that is actually counting very good
2. The ckeditor5 has not any input or textarea and the plugin is not applied well.

In conclusion...we probably need to look at: https://ckeditor.com/docs/ckeditor5/latest/features/word-count.html

I've reproduced the issue for Administrator role. And I don't have hidden textarea per #3
It looks interesting that issue is not reproducible for other custom roles.
Drupal 9.3.16, maxlength 2.0.0-rc2

Vera, thanks for reporting this issue.

Andrei and Dzianis, thank you for investigating the issue further.

I've elaborated on the steps to reproduce, what I'm seeing on my end and links to resources that might be helpful.

If any of you (or anyone else reading this) is interested in working on this, let me know. Myself and the other maintainers don't have time at the moment to work on this, but would be happy to support others as best we can.

Now that Drupal 9.5 & 10 have been released, this issue seems to have become even more important. I can confirm that under Drupal 9.5 and CKEditor 5 the function is no longer given. It would be nice if we could address this issue a bit more actively now that CKEditor 4 is deprecated and sooner or later everyone will switch to version 5.

Hi all,

We agree this is a major issue. Unfortunately us maintainers don't have capacity at the moment to actively work on this issue. I've added a note about the bug on the project page so people are aware of MaxLength's current incompatibility with CKEditor 5.

If anyone from the broader Drupal community has time to work on this we would greatly appreciate it.

Both my time and knowledge of CKEditor 5 are limited, so I can't contribute anything substantial right now. But at least I added this module to CKEditor 5 Upgrade Coordination docs page for visibility.

Thank you, that's helpful!

If you want, please have a look at my approach in https://git.drupalcode.org/project/maxlength/-/merge_requests/25 .

I'm repsecting the "Hard limit" option as well as syncing the textfield with the contents of the editor.
This way, maxlength counting works again.

I'm sure there's better approaches to solving this, but I didn't find any better.

Hi @fisherman90,

I tested out your commit, and it works fine.
I have a question though. I am trying to remove from the total count number, the spaces and the line breaks.
Do you have any idea how to achieve this?

Thanks!

@bogdanstamate06 I've tried removing the total count number from the "Count down message" (is that what you meant?).
Also in case I understood it differently, I reduced the "Max length" Number for an already existing field, which also seems to work with spaces / lines.

Are you sure this has something to do with this issue? Or is it maybe another Problem you are running into?
Sounds like maybe your text formats need to have a look at.

At least for now I cannot reproduce that the spaces / line breaks get broken by the change.
If this is still an issue for you and does not come from text formats or so: Can you post a reproductible scenario for me, so I can try to get the error on my setup, too?

Excellent! I've tested fisherman90's merge request and it's working great on both CKE5 and 4. I believe all our test coverage is CKE-version agnostic, but I will confirm with the other maintainers.

I also tested fisherman90's merge request with CKE5, and it looks good, the countdown is working as expected.

All works fine for me as well however, I'm working on implementing test coverage for both CKE versions.

Implemented tests for CKEditor5.

Seems there is a problem over D10. As the tests are failing and I confirm after manual testing too that the character count doesn't work over D10. On D9 it works fine with CKEditor5, as you can see on the tests as well.

Alright, D10 is passing now as well after the fix.

Thanks for updating the merge request Joe.

This fix needs a bit more work. If I set this to be a Hard Limit, when I reach the end of the limit and I keep typing, the text I type ends up being added to the beginning of the body field.

Over D9.5.2+CKE4 and D10+CKE5 I could reproduce the issue and I can make characters appear at the first position only if I spam the keyboard, but thats due to the fact that the JS re-inserts the value and at that point the cursor is not at the end position because the wysiwyg is empty. This issue was present from before, not related to the CKE5 integration code. We might need a different issue for that to handle.

I pushed a potential fix for the problem described in #25.

However, I found a problem when typing and pressing SHIFT+ENTER for new line I get the
alert('Expected end tag: ' + expected_tag_name + '; Found end tag: '+tag_name);
kick in making the browser tab unusable, need to close and reopen the page. Not sure if it is due to my text filter + editor configuration or it is an actual issue. Need to look into it.

I made a commit that adds annotations to the functions we have in the JS. Sorry for the noise, but I really needed to document the code properly because it is very difficult to get around the legacy code without proper documentation.

Unfortunately with the latest version of the merge request the counter is not updating at all. I've tested this with Drupal 9.5.3 and Drupal 9.5.4. I also tried flushing all caches and testing again.

For me it works fine, I reinstalled the whole thing and can't reproduce the problem. And the automated tests are passing too.

Fixed the issue with the single closing element thanks to @Chewie. Adapted the ckeditor tests accordingly.

Confirmed that the page breaks and other singleton HTML tags now work as expected.

I was able to figure out why the counter was not working in some cases.

If my text format starts in CKEditor 4 and I switch to CKEditor 5, then the counter no longer updates. If I save the node and then return to the edit form then the counter and limit method works as expected.

I think we can open a separate issue for that and proceed with this fix, but curious what other maintainers thinks. This also needs a code review from one other maintainer.

Upon further testing if you include an image or video within a text field with MaxLength is triggers an infinite loop. The single closing element issue still needs some more work.

I had a further testing round on the fix from the MR 25
Still having issue of not updated remaining: count status.

Tested MR 25 for the 2nd round with

Maximum length: 200
Maximum summary length: 200

It's working well

Had a 3rd round with

Maximum length: 200

But no

Maximum summary length: 200

Title, Body field with summary limit

Title, Body field with no summary limit

Hi,

Works for me with ckeditor 5

Thank you!

I just tested this with an image in the text field and it's now working as expected. I also tested with
and tags. Those too are working as expected.

Once this receives a code review from a maintainer this will be ready to merge into 2.1.x and we can issue a new release. Exciting!

Looks good to me! Elements with attributes are working and nothing stood out to me in the code review.

FYI I have opened this back up. #3276563: [Meta] Create new major branch and add support for CKEditor 5