As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#7 list-of-files.png27.25 KBamit.drupal
#6 mass_contact_file_tag_docblock_search.png59.65 KBdhruveshdtripathi
#4 2868502-5.patch10.69 KBPavan B S
#2 2868502-2.patch10.46 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
2868502-2.patch10.46 KB

Applying the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: 2868502-2.patch, failed testing.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
FileSize
2868502-5.patch10.69 KB

Re applying the patch, with error removed from the patch

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Status: Needs work » Needs review
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
FileSize
mass_contact_file_tag_docblock_search.png59.65 KB

Patch applied cleanly. All the necessary t() functions replaced with $this->t() and all the @file tag docblocks are removed from .php files.

Good work!

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
list-of-files.png27.25 KB

After Apply patch all t() replace with $this->t() and @file remove in .php file

Review Patch #4. Its work nicely .Attach list of modified files.

  • jhedstrom committed 00c0d30 on 8.x-1.x authored by Pavan B S 
    Issue #2868502 by Pavan B S, dhruveshdtripathi, amit.drupal: Remove @...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.