Problem/Motivation

The user view modes all seem to get a visible component added to them for masquerade links, this makes the compact view mode (used for displaying user pictures on articles) get the link.

Proposed resolution

Only add the link to the default view_mode.

Remaining tasks

Write Patch

User interface changes

The article meta data will not have masquerade component added to the links by default.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#10 2923845-10.patch1.72 KBandypost
#10 interdiff-4.txt1.08 KBandypost
#4 2923845-4.patch1.78 KBandypost
#4 2923845-test-only.patch1.21 KBandypost
#2 2923845-2.patch585 bytesandypost

Issue fork masquerade-2923845

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks
    Support from Acquia helps fund testing for Drupal Acquia logo

    Comments

    joelpittet created an issue. See original summary.

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    CreditAttribution: andypost as a volunteer and at Skilld commented
    Status: Active » Needs review
    FileSize
    2923845-2.patch585 bytes

    btw no idea how to hide it from manage display screen

    Status: Needs review » Needs work

    The last submitted patch, 2: 2923845-2.patch, failed testing. View results
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    CreditAttribution: andypost as a volunteer and at Skilld commented
    Status: Needs work » Needs review
    FileSize
    2923845-test-only.patch1.21 KB
    2923845-4.patch1.78 KB

    Test & patch

    The last submitted patch, 4: 2923845-test-only.patch, failed testing. View results

    joelpittet’s picture

    joelpittet
    Primary language English
    Location Vancouver
    CreditAttribution: joelpittet at The University of British Columbia commented
    Status: Needs review » Reviewed & tested by the community

    I think that would do the trick, thanks @andypost

    Berdir’s picture

    Berdir
    Primary language German
    Location Switzerland
    CreditAttribution: Berdir at MD Systems GmbH commented

    A comon approach is to set the extra field to not be displayed by default at all ('visible' => FALSE), then it can be enabled for the view modes where it should be (e.g. in hook_install() it could be put in the default view mode).

    joelpittet’s picture

    joelpittet
    Primary language English
    Location Vancouver
    CreditAttribution: joelpittet at The University of British Columbia commented

    That approach would be better IMO thanks @Berdir. I'll let @andypost decide.

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    CreditAttribution: andypost as a volunteer and at Skilld commented
    Status: Reviewed & tested by the community » Needs work

    hook_install approach looks better

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    CreditAttribution: andypost as a volunteer and at Skilld commented
    Status: Needs work » Needs review
    FileSize
    interdiff-4.txt1.08 KB
    2923845-10.patch1.72 KB

    Here's a patch with install hook, existing sites does not need update so no update hook

    Status: Needs review » Needs work

    The last submitted patch, 10: 2923845-10.patch, failed testing. View results

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    CreditAttribution: andypost as a volunteer and at Skilld commented

    Somehow "masquerade" in build array - probably install hook is not executed in kernel tests

    andypost’s picture

    andypost
    he/him
    Primary language Russian
    CreditAttribution: andypost as a volunteer and at Skilld commented
    Parent issue: » #2982514: Masquerade 8.x-2.0 stable release plan