Problem/Motivation

Banner navigation arrow are not missing on theme installation.

Steps to reproduce

Install the theme, and visit the home page

CommentFileSizeAuthor
#10 Welcome-Drush-Site-Install (4).png786.75 KBnupur badola
#8 BeforeMR-1.png390.4 KBkanchan bhogade
#8 AfterMR-1.png392.6 KBkanchan bhogade
#7 slider-arrow1.png1 MBkaaarrrtik
#7 slider-arrow-2.png1.08 MBkaaarrrtik
#4 Screenshot from 2024-04-02 11-19-45.png827.28 KBabhishek_gupta1
Screenshot 2024-03-28 at 4.32.22 PM.png1.46 MBashutosh ahirwal

Issue fork market_wave-3436703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ashutosh Ahirwal created an issue. See original summary.

yogesh.k’s picture

yogesh.k commented
Assigned: Unassigned » yogesh.k
yogesh.k’s picture

yogesh.k commented
Version: 1.0.0 » 1.0.1
Status: Needs work » Needs review
abhishek_gupta1’s picture

abhishek_gupta1 commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-04-02 11-19-45.png827.28 KB

I have verified the issue and issue is still there. Not fixed. please refer screenshot

kaaarrrtik made their first commit to this issue’s fork.

kaaarrrtik opened merge request !1

kaaarrrtik’s picture

kaaarrrtik commented
Status: Needs work » Needs review
StatusFileSize
new slider-arrow-2.png1.08 MB
new slider-arrow1.png1 MB

Slider arrow issue fixed . Only local images are allowed.Slider issue fixed

kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new AfterMR-1.png392.6 KB
new BeforeMR-1.png390.4 KB

Hi,
I've tested MR !1 on Drupal 10
MR is applied cleanly...

Test Result:
Banner navigation arrows are getting a load.
Adding SS for reference

RTBC+1

Keeping "Needs review" for code verification

kanchan bhogade’s picture

kanchan bhogade commented
Assigned: yogesh.k » Unassigned
nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Welcome-Drush-Site-Install (4).png786.75 KB

Reviewed MR!1, it is working for me.

luismagr made their first commit to this issue’s fork.

luismagr’s picture

luismagr commented

Hi all,

First of all, thanks for the theme! It looks really nice.

I've checked this issue because I saw the same problem while testing it. The code looks good to me and works but the fork needed an update. I updated it following the instrucctions and pushed the change. I'm not sure if I did correctly but let me know if you see I broke something.

Thanks

  • yogesh.k committed 985b0be7 on 1.0.x authored by kaaarrrtik 
    Issue #3436703: Banner navigation arrows not getting load on theme...
yogesh.k’s picture

yogesh.k commented
yogesh.k’s picture

yogesh.k commented
Version: 1.0.1 » 1.0.4
Status: Reviewed & tested by the community » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)