The link to the screenshot does not work

http://drupal.org/node/1134044

CommentFileSizeAuthor
#2 broken-link-2054871-2.patch3.65 KBarunkumark

Issue fork mailsystem-2054871

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr’s picture

tr commented
Title: Correct the documentation on the project / readme page » Correct broken link in README
Version: 7.x-2.7 » 8.x-4.x-dev
Issue summary: View changes
Priority: Normal » Minor

Broken link still appears in D8 documentation. It is no longer on the project page. Should be fixed in D8 first.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Active » Needs review
Issue tags: +Novice
StatusFileSize
new broken-link-2054871-2.patch3.65 KB

The broken links have been removed from the README files.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Parent issue: » #2841134: Update README
jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40

I will review this patch.

jatingupta40’s picture

jatingupta40 commented
Assigned: jatingupta40 » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch is absolutely fine. Moving to RTBC

kunal_sahu made their first commit to this issue’s fork.

kunal_sahu’s picture

kunal_sahu commented
Assigned: Unassigned » kunal_sahu
Status: Reviewed & tested by the community » Needs work

Hi , Your patch applied perfectly, will commit the changes shortly.
Thanks

kunal_sahu opened merge request !6

kunal_sahu’s picture

kunal_sahu commented
Assigned: kunal_sahu » Unassigned
Status: Needs work » Needs review

schillerm made their first commit to this issue’s fork.

schillerm’s picture

schillerm commented

Hi, reviewed the MR and noticed that the numbering was wrong in README.txt. So I fixed that and pushed the change up .

skt-001’s picture

skt-001 commented
Status: Needs review » Reviewed & tested by the community

MR 6 is working fine with correct numbering i moving status to RTBC.

tr’s picture

tr commented
Status: Reviewed & tested by the community » Needs work

No, a bunch of links are still broken. Note mail.inc no longer exists, so all those links to the mail.inc api documentation don't work. Likewise, the links to the api pages should not end in /8 as that specifies an exact core version. If you leave that off it will redirect to the page for the current core version. And why delete the link to the screenshot? That was and still is useful documentation. Correct the link instead of deleting it! If the image is no longer on drupal.org, then take a screenshot, upload it, and link to that new screenshot. Don't just throw away valuable information ...

koustav_mondal’s picture

koustav_mondal commented
Assigned: Unassigned » koustav_mondal

Working on it.

koustav_mondal’s picture

koustav_mondal commented
Assigned: koustav_mondal » Unassigned
Status: Needs work » Needs review

Hello @tr, I just removed /8 at the end, but the link is still redirecting to a broken page. I found that the link is only available with Drupal 7.x. So I added /7 at the end. Now the mail.inc API documentation links are working. But I don't know how to host the image. I'll appreciate it if anyone comes to fix that portion. Thanks in advance.

tr’s picture

tr commented
Status: Needs review » Needs work