[PATCH] Extract mailsystem_html_to_text into a submodule [#1538148]

In order to confine the responsibilities of the mailsystem module, the mailsystem_html_to_text method is extracted into a separate independent submodule.

Comment	File	Size	Author
#6	1538148-Extract-mailsystem_html_to_text-into-a-submodule.patch	59.35 KB	znerol
#6
	0001-Extract-mailsystem_html_to_text-into-a-submodule.patch	59.91 KB	znerol

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pillarsdotnet CreditAttribution: pillarsdotnet commented 19 April 2012 at 11:59

Status:

Active

» Closed (won't fix)

Actually, it should be a core patch.

Comment #2

znerol CreditAttribution: znerol commented 19 April 2012 at 16:15

OK, would it be possible to remove the code from mailsystem completely?

Comment #3

pillarsdotnet CreditAttribution: pillarsdotnet commented 20 April 2012 at 17:48

As soon as it gets patched in core, yes.

If you have a problem with how mailsystem_html_to_text() is implemented, I would entertain a patch either to fix it or to let the user choose between the system version and the improved version included with mailsystem.

Comment #4

znerol CreditAttribution: znerol commented 20 April 2012 at 19:15

If you have a problem with how mailsystem_html_to_text() is implemented

I do not use mailsystem_html_to_text at all, my long term goal is to get rid of the hook_init implementation in mailsystem. The method mailsystem_html_to_text is referenced there at the moment and I'm just offering an alternative approach.

let the user choose between the system version and the improved version included with mailsystem.

That is exactly the purpose of this patch: Extract it into its own module plus wrap it into a EnhancedHTMLtoTextMailsystem class such that users may select it as the formatter class in the mailsystem admin ui. Currently it is not exposed at all to end users.