Port Mailsave to Mailhandler 2.x

Great to hear!

I was interested because I'm trying to get attachments from messages using Mailhandler 2.x. I spent the morning working on it, and I'm pretty close to having a working module for at least a subset of Mailsave's functionality (namely, saving attachments to a FileField/ImageField). I'd be happy to contribute my code once complete. The changes from Mailhandler 1.x to 2.x are pretty drastic, and it appears the functionality that was in Mailsave can be done in a fraction of the code.

After spending some more time with it, I think the attachment saving functionality should just be a part of Mailhandler itself: Feeds does 95% of all the heavy lifting now; the only thing Mailhandler needs to do is save the files to a temp directory.

I created a patch for Mailhandler here: #927014: Provide e-mail attachments as FeedEnclosure objects to support FileField mappings

I didn't touch the cleaning filters; perhaps that could be the basis for a Mailsave 2.x that interacts with Mailhandler 2.x should the changes I proposed to Mailhandler get committed.

Mailhandler 2.x, as it is now, maintains those abilities: all MIME parts are stored in $object->mimeparts more-or-less untouched (Mailhandler decodes the data using imap_base64, quoted_printable_decode(), and imap_utf8 before saving to $object->mimeparts).

In fact, the patch I provided relies on that to identify MIME parts that have file names. My patch creates a new property and leaves the original mimeparts property untouched so other modules can act on it.

I had to clean up e-mail HTML tonight for a project I'm working on so I could convert messages to Markdown, and I was able to do it successfully with hook_feeds_after_parse(). This is what I used; it should work as a template for any cleanup module:

 function test_feeds_after_parse(FeedsImporter $importer, FeedsSource $source) {
  // Figure out the mimetype of the body
  $fetched = $source->batch->getRaw();
  $mime = explode(',', $fetched['mailbox']->mime);
  
  // We only want to convert HTML e-mails.
  if ($mime[0] === 'TEXT/HTML') {
    $messages = array();

    // Remove each message from the batch and act on them
    while ($item = $source->batch->shiftItem()) {
      // Act on the original body.
      if ($item['origbody']) {
        $item['origbody'] = _test_cleanup($item['origbody']);
        $item['origbody'] = _test_html_to_markdown($item['origbody']);
      }
      
      $messages[] = $item;
    }
  }
  
  // Add the modified messages back to the batch.
  $source->batch->setItems($messages);
}

If you wanted to act on the MIME parts, you'd modify $item['mimeparts'] instead.