Fix getFrom() usage in Mailhandler [#2826094]

Follow-up to #2824962: Update Mailhandler with Inmail Mime changes

Problem/Motivation

Inmail provides getFrom() helper method in form of an array while Mailhandler relies on string value.

Proposed resolution

Get string value from getFrom() and fix a leftover (MultipartEntity -> MimeMultipartEntity) from #2824962: Update Mailhandler with Inmail Mime changes

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#8	fix_getfrom_usage_in-2826094-8-interdiff.txt	1000 bytes	mbovan
#8	fix_getfrom_usage_in-2826094-8.patch	2.9 KB	mbovan
#8	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 15 pass PHP 7 & MySQL 5.5, D8.3 15 pass
#3	fix_getfrom_usage_in-2826094-3.patch	1.93 KB	mbovan
#3	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 14 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 14 pass, 2 fail
#2	remove_field_value-2820667-8.patch	4.8 KB	mbovan
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.3 Patch failed to apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

9 November 2016 at 15:53

mbovan created an issue. See original summary.

Comment #2

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 9 November 2016 at 15:55

Status:

Active

» Needs review

File	Size
remove_field_value-2820667-8.patch	4.8 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.3 Patch failed to apply

Updated getFrom() usages and fixed the leftover. Let's check the test bot.

Comment #3

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 9 November 2016 at 15:59

File	Size
fix_getfrom_usage_in-2826094-3.patch	1.93 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 14 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 14 pass, 2 fail

1 file was hidden/shown/deleted

File	Size
remove_field_value-2820667-8.patch	4.8 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.3 Patch failed to apply

Ooops... Uploaded a correct patch.

Comment #4

9 November 2016 at 16:01

The last submitted patch, 2: remove_field_value-2820667-8.patch, failed testing.

Comment #5

9 November 2016 at 16:02

The last submitted patch, 2: remove_field_value-2820667-8.patch, failed testing.

Comment #6

9 November 2016 at 16:05

Status:

Needs review

» Needs work

The last submitted patch, 3: fix_getfrom_usage_in-2826094-3.patch, failed testing.

Comment #7

9 November 2016 at 16:06

The last submitted patch, 3: fix_getfrom_usage_in-2826094-3.patch, failed testing.

Comment #8

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 9 November 2016 at 16:27

Status:

Needs work

» Needs review

File	Size
fix_getfrom_usage_in-2826094-8.patch	2.9 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 15 pass PHP 7 & MySQL 5.5, D8.3 15 pass
fix_getfrom_usage_in-2826094-8-interdiff.txt	1000 bytes

Fix for MailhandlerWebTest.

Comment #9

9 November 2016 at 16:32

mbovan committed fb56683 on 8.x-1.x

Issue #2826094 by mbovan: Fix getFrom() usage in Mailhandler

Comment #10

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 9 November 2016 at 16:33

Status:

Needs review

» Fixed

Green! Committed. :)

Comment #11

23 November 2016 at 16:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #12

maxilein CreditAttribution: maxilein commented 17 March 2017 at 15:07

This patch obviously did not make it to the latest dev version!

The latest dev version contains the erroneous line:

- $from = $message->getFrom()->getAdress();

This patch contains the line: BUT it is NOT in the dev version!
+ $from = $message->getFrom()['address'];

But the only line that really works can be found in my patch over here: https://www.drupal.org/node/2850498#comment-11991993
$from = $message->getFrom()[0]->getAddress();