The confirmation message and the submit button of the subscribe block is not translateable.

CommentFileSizeAuthor
#17 translate_submit_and_message-2932189-17.patch5.56 KBanoopsingh92
#9 translate_submit_and_message-2932189-9.patch23.27 KBdrupal.ninja03
#9 interdiff-2932189-7-9.txt24.03 KBdrupal.ninja03
#7 translate_submit_and_message-2932189-7.patch2.53 KBjoco_sp
#2 2932189-2_translate_block_button_and_message.patch1.05 KBytsurk

Issue fork mailchimp-2932189

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
CreditAttribution: ytsurk commented
Status: Active » Needs review
FileSize
2932189-2_translate_block_button_and_message.patch1.05 KB
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

Well I think it would be cleaner to solve this via configuration translation, but the patch can be seen as hotfix....

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Needs work

@Anybody I agree - some values that come directly from Mailchimp may need wrapped in t(), but values from config entities should be translatable. What do we need to do to enable that in the module?

ytsurk’s picture

ytsurk
Location Switzerland
CreditAttribution: ytsurk commented

It needs a correct configuration schema, according to https://www.drupal.org/docs/8/multilingual/translating-configuration, i have not reviewed the one in this module so far.

This then probably will need an update hook for existing installations ... so good testing is needed

mvonfrie’s picture

mvonfrie CreditAttribution: mvonfrie commented

There are some other UI texts which need to be translated, e. g. the #2968016: Add GDPR checkbox for opt-in consent consent message. Please make all texts translatable!

We are using this module in a site which currently is translated to English, German and Czech will follow within the next months. As many of the users of that site don't speak English we need to translate everything. Thanks.

joco_sp’s picture

joco_sp CreditAttribution: joco_sp commented
Category: Feature request » Bug report
Status: Needs work » Needs review
FileSize
translate_submit_and_message-2932189-7.patch2.53 KB

I changed the category to Bug report, becasue if you have a multilingual site you can't translate those strings.

I updated the patch, so it should work with the latest dev version of the module. I also found two descriptions on the form without the translation possibilities.

joco_sp’s picture

joco_sp CreditAttribution: joco_sp commented

The patch for the 8.1.11 version is here - https://www.drupal.org/project/mailchimp/issues/3145660#comment-13663886

drupal.ninja03’s picture

drupal.ninja03 CreditAttribution: drupal.ninja03 at TA Digital commented
Issue tags: +Coding standards, +@deprecated
FileSize
interdiff-2932189-7-9.txt24.03 KB
translate_submit_and_message-2932189-9.patch23.27 KB

I have added more changes for the deprecated t() calls.

gcb’s picture

gcb
he/him
CreditAttribution: gcb as a volunteer and at ThinkShout commented
Assigned: Unassigned » 5adiyah
gcb’s picture

gcb
he/him
CreditAttribution: gcb as a volunteer and at ThinkShout commented
Assigned: 5adiyah » spncr
Shashwat Purav’s picture

Shashwat Purav CreditAttribution: Shashwat Purav at Portage CyberTech for Drupal Association commented
Status: Needs review » Needs work

The patch in #9 failed to apply to 8.x-1.x branch.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented

Hi

Anyone is working on this issue? Because I am not seeing any activity from the last 3 months on that issue. If someone is not working then I request you to please realize it and change it to unassigned.

Thank You

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented

Hello @spncr,

I want to review the provided patches. If I will get any issues with the patches or other things then I will try to provide a clean patch for this.
Thanks

gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Assigned: spncr » Unassigned

Hey @anoopsingh92. @spncr isn't working on this project anymore. I've unassigned this ticket. Any feedback or testing results you have would be welcome.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented
Assigned: Unassigned » anoopsingh92

Hi @gcb,

Thank you so much for thae change assign value as unassigned. Now i will check this ticket if i will get any issue on this then i will try to fix and give my feedback on this.

I am working on it.

Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented
Assigned: anoopsingh92 » Unassigned
Status: Needs work » Needs review
FileSize
translate_submit_and_message-2932189-17.patch5.56 KB

Hello,
Please review this patch. I didn't change related to the Coding standards in this patch.
Thanks

xenophyle’s picture

xenophyle CreditAttribution: xenophyle commented

It looks like the changes from the latest patch exist in the current 2.x dev branch. Does anything else need to be done to close this issue?

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented

I see that indeed everything in #17 is addressed.

I do however see in the code base that there is more usage of literal strings where I think that translated strings should be used. You could search in the code base for:

  • '#title' => '
  • '#title' => "

Note: on '#description' I did not find anything that should be changed.

Would it be good to address '#title' strings translations here, or is that out of scope?

xenophyle’s picture

xenophyle CreditAttribution: xenophyle commented

@MegaChriz Might as well make translatable strings a new issue.