We do not need the version to be declared in composer.json anymore. In fact, doing so causes composer to work strangely and to often fail with the error:

[UnexpectedValueException]
Invalid version string "7.x-4.7"

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

bangpound created an issue. See original summary.

Anonymous’s picture

krina.addweb’s picture

Hi,
Thanks for the patch it cures the "Invalid version string "7.x-4.7" " error. but after applying your patch it gives me another error,
"Your requirements could not be resolved to an installable set of packages.
Problem 1
The requested package thinkshout/mailchimp-api-php >=1.0.6 is satisfiable by thinkshout/mailchimp-api-php[dev-master] but these conflict with your requirements or minimum-stability."

krina.addweb’s picture

Status: Needs review » Needs work
FrittenKeeZ’s picture

The problem regarding "The requested package thinkshout/mailchimp-api-php >=1.0.6 is satisfiable by thinkshout/mailchimp-api-php[dev-master] but these conflict with your requirements or minimum-stability." is due to the wrong version specified in the library. See https://github.com/thinkshout/mailchimp-api-php/issues/51
To fix this change the required version to 'dev-master' temporarily in mailchimp/composer.json and run composer update.

MegaChriz’s picture

Status: Needs work » Reviewed & tested by the community

Version strings in a composer.json file should be in a format like x.y.z, not x.x-x.x. Therefore, the version string as it is now, is wrong. Removing it seems the right thing to do.

@krina.addweb
Your issue already reported in #2850362: 7.x-4.8 requires non-existing mailchimp-api-php 1.0.6.

MegaChriz’s picture

Automated tests fail because of this bug: https://dispatcher.drupalci.org/job/drupal_d7/1067/console

19:13:53 Installation failed, reverting ./composer.json to its original content.
19:13:53
19:13:53
19:13:53 [UnexpectedValueException]
19:13:53 Invalid version string "7.x-4.7"

  • ruscoe committed ca0b371 on 7.x-4.x authored by bangpound
    Issue #2851901 by bangpound, krina.addweb, MegaChriz, FrittenKeeZ:...
ruscoe’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the patch! The v1.0.6 release of the library has also been fixed.

krina.addweb’s picture

@ruscoe,I guess you forgot to provide me RTBC credit, can you please do the needful.

ruscoe’s picture

Hi @krina.addweb, you're credited in the commit message (screenshot attached).

Is there another way you'd like to be credited that I missed?

krina.addweb’s picture

@ruscoe, I think as much I know during commit process from "credit & commit", to whom you want to provide credit,you have to check the check box before his/her name . And also you can do the needful commit again for providing credit.
You may be right but I didn't received credit that's why.

Greg Boggs’s picture

Hi Krina,

It's great that you're interested in getting commit credit for patches on MailChimp! We'll gladly get any completed patches you write committed. That way, you'll get the authorship credit on the patches.

To find a list of of active issues waiting for new patches, check out the list for something that interests you:

https://www.drupal.org/project/issues/mailchimp?text=&status=1&prioritie...

~Greg

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andrey_zb’s picture

@ruscoe Could you please review and commit this patch? The issue is still present in the latest module version.

Greg Boggs’s picture

Status: Closed (fixed) » Needs review
ruscoe’s picture

There's a new release happening either today or tomorrow at the latest. This patch has been committed to the dev branch and will make it into that release.

ruscoe’s picture

Status: Needs review » Fixed

Fixed in 7.x-4.9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.