Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We do not need the version to be declared in composer.json anymore. In fact, doing so causes composer to work strangely and to often fail with the error:
[UnexpectedValueException]
Invalid version string "7.x-4.7"
Comment | File | Size | Author |
---|---|---|---|
#11 | Screen Shot 2017-02-18 at 9.01.38 AM.png | 85.9 KB | ruscoe |
#2 | mailchimp-remove-version-composer.patch | 345 bytes | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commentedbangpound created an issue. See original summary.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commentedEh. I uploaded the wrong file the first time!
Comment #3
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commentedHi,
Thanks for the patch it cures the "Invalid version string "7.x-4.7" " error. but after applying your patch it gives me another error,
"Your requirements could not be resolved to an installable set of packages.
Problem 1
The requested package thinkshout/mailchimp-api-php >=1.0.6 is satisfiable by thinkshout/mailchimp-api-php[dev-master] but these conflict with your requirements or minimum-stability."
Comment #4
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commentedComment #5
FrittenKeeZ CreditAttribution: FrittenKeeZ commentedThe problem regarding "The requested package thinkshout/mailchimp-api-php >=1.0.6 is satisfiable by thinkshout/mailchimp-api-php[dev-master] but these conflict with your requirements or minimum-stability." is due to the wrong version specified in the library. See https://github.com/thinkshout/mailchimp-api-php/issues/51
To fix this change the required version to 'dev-master' temporarily in mailchimp/composer.json and run composer update.
Comment #6
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedVersion strings in a composer.json file should be in a format like x.y.z, not x.x-x.x. Therefore, the version string as it is now, is wrong. Removing it seems the right thing to do.
@krina.addweb
Your issue already reported in #2850362: 7.x-4.8 requires non-existing mailchimp-api-php 1.0.6.
Comment #7
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedAutomated tests fail because of this bug: https://dispatcher.drupalci.org/job/drupal_d7/1067/console
Comment #9
ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commentedThanks for the patch! The v1.0.6 release of the library has also been fixed.
Comment #10
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@ruscoe,I guess you forgot to provide me RTBC credit, can you please do the needful.
Comment #11
ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commentedHi @krina.addweb, you're credited in the commit message (screenshot attached).
Is there another way you'd like to be credited that I missed?
Comment #12
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@ruscoe, I think as much I know during commit process from "credit & commit", to whom you want to provide credit,you have to check the check box before his/her name . And also you can do the needful commit again for providing credit.
You may be right but I didn't received credit that's why.
Comment #13
Greg BoggsHi Krina,
It's great that you're interested in getting commit credit for patches on MailChimp! We'll gladly get any completed patches you write committed. That way, you'll get the authorship credit on the patches.
To find a list of of active issues waiting for new patches, check out the list for something that interests you:
https://www.drupal.org/project/issues/mailchimp?text=&status=1&prioritie...
~Greg
Comment #15
andrey_zb CreditAttribution: andrey_zb as a volunteer commented@ruscoe Could you please review and commit this patch? The issue is still present in the latest module version.
Comment #16
Greg BoggsComment #17
ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commentedThere's a new release happening either today or tomorrow at the latest. This patch has been committed to the dev branch and will make it into that release.
Comment #18
ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commentedFixed in 7.x-4.9.