Problem/Motivation

Some administration form elements use strings instead of using t(). As a result, not all administration form titles and descriptions can be localized.

Proposed resolution

Use the 

\Drupal\Core\StringTranslation\StringTranslationTrait $this->t()

so strings can be localized.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The administrative interface may appear localized when opened in a language other than English.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 2779643-mailchimp_signup_schema_update-4.patch1.22 KBSchnWalter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr commented
Title: Make all administration form element titles/descri translatable » Make all administration form element titles/descriptions translatable
SchnWalter’s picture

SchnWalter CreditAttribution: SchnWalter as a volunteer and commented

If you are referring to the title and description for the mailchimp_signup config entities, then the mailchimp_signup.mailchimp_signup.* schema should be updated to use text instead of strings.

I'll provide a patch, soon.

SchnWalter’s picture

SchnWalter CreditAttribution: SchnWalter as a volunteer and commented
FileSize
2779643-mailchimp_signup_schema_update-4.patch1.22 KB

Applying this patch will make all string on the "Signup Forms" (admin/config/services/mailchimp/signup) configuration entities translatable.

SchnWalter’s picture

SchnWalter CreditAttribution: SchnWalter as a volunteer and commented

Please ignore previous patch.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Active » Closed (outdated)

It looks like this change already happened in 8.x-1.x, I'm guessing from another issue.