Underscores in token types [#2542560]

By default mailchimp_lists.field.inc uses underscores in the token type for merge fields - eg. [commerce_customer_profile:field-email]. Some modules (eg. commerce_customer) define the token type using hyphens, which seems to be the standard (https://www.drupal.org/node/1302056), and token_replace fails to replace the token.

Attached patch replaces underscores with hyphens in the token type.

Comment	File	Size	Author
#3	mailchimp-token_type_underscore-2542560-3.patch	2.1 KB	bgilhome
#3	7.x-3.x: PHP 5.4 & MySQL 5.5 CI error
#2	mailchimp-token_type_underscore-2542560-2.patch	793 bytes	bgilhome
#2	7.x-3.x: PHP 5.4 & MySQL 5.5 CI error
#1	mailchimp-token_type_underscore-2542560-1.patch	850 bytes	bgilhome
#1	7.x-3.x: PHP 5.4 & MySQL 5.5 CI error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bgilhome CreditAttribution: bgilhome commented 30 July 2015 at 07:39

File	Size
mailchimp-token_type_underscore-2542560-1.patch	850 bytes
7.x-3.x: PHP 5.4 & MySQL 5.5 CI error

Comment #2

bgilhome CreditAttribution: bgilhome commented 30 July 2015 at 08:30

File	Size
mailchimp-token_type_underscore-2542560-2.patch	793 bytes
7.x-3.x: PHP 5.4 & MySQL 5.5 CI error

Actually, mailchimp_lists_fieldmap_options() is a better place to put it - $key is already replaced, just replace $entity_type as well. Updated patch attached.

Comment #3

bgilhome CreditAttribution: bgilhome commented 31 July 2015 at 00:09

File	Size
mailchimp-token_type_underscore-2542560-3.patch	2.1 KB
7.x-3.x: PHP 5.4 & MySQL 5.5 CI error

Also, this should apply to the 'available tokens' field and the field validation function. Updated patch attached.

Comment #4

jami CreditAttribution: jami at ThinkShout for Mailchimp commented 31 August 2015 at 22:33

Assigned:

Unassigned

» jami

Comment #5

jami CreditAttribution: jami at ThinkShout for Mailchimp commented 3 October 2015 at 00:20

Assigned:

jami

» Unassigned

Comment #6

ruscoe CreditAttribution: ruscoe at ThinkShout commented 4 October 2016 at 17:56

Status:

Needs review

» Closed (won't fix)

We're going to be ending support for the 7.x-3.x branch due to the upcoming deprecation of the v2.0 MailChimp API. If you're still seeing this issue with the most recent release, please feel free to reopen.