Existing subscriber data overwritten when using a signup form

This is not possible for an anonymous user, and you probably shouldn't mix existing segmented lists with a generic sign up form available to anonymous users on the site. Regardless, it's not a problem the module can solve.

Sorry to open such an old issue, but i also have the same situation, which I currently get by with a modified version of the module which i'd prefer not to do. I'm using 6.x-2.x but i see the issue is still present in 7.x-2.x.

Keeping email addresses in a single list and separating subscriptions using groups is something that mailchimp recommend and also makes financial sense as you don't pay multiple times for people that have multiple subscriptions.

There is a relatively simple way to give an option, either through the ui or through some kind of hook.

The api function listUpdateMember has a parameter - $replace_interests, which by default is true. If its set to false, it means that any ticked interests groups would be *added* to any users existing interest groups.

 function listUpdateMember($id, $email_address, $merge_vars, $email_type='', $replace_interests=true) {
...
} 

Obviously not suitable for authenticated users, but perfect for anonymous users where we don't have their default groups.

My suggestion would be to add a new optional parameter to _mailchimp_subscribe_user (in 6.x-2.x) and mailchimp_update_user in (7.x-2.x)

Then in mailchimp_subscribe_anon_form_submit (or the 7.x-2.x) alternative, the replace_groups parameter could be passed in, perhaps based on a variable for the current list.

Here is a patch for 6.x-2.x for your consideration.

I added an option for preserving the interest groups to the user settings fieldset, when this is checked any interest groups selected will be added to those already set for the subscriber.

I set the option to default to false as i didn't want to change the behaviour, but I personally I would think it would be more common to want to preserve the groups than replace them.

Had same problem for 7.x-3.x. I think it is incorrect that this shouldn't be supported - when is it the case that you what a subscription form to also "unsubscribe" you to something? I have solved it with the following patch which I think should be adapted - didn't thought it should be an option as the form is a subscription form and therefore shouldn't do unsubscribing stuff.

Corrected the patch made in comment #4, so it's now an option on the creation if it's preferred to preserve interest groups or not - defaults to true. Also added a setting for an update message when an email is submitted but already is subscribing.

Same issue, patch #6 seems to have fixed it for me.

Made the patch for the newest develop, please adopt this patch!

@levelos: can you review and explain in more detail why this shouldn't be done?

Quick code review.

1. +++ b/modules/mailchimp_signup/includes/mailchimp_signup.admin.inc
   @@ -97,6 +97,13 @@ function mailchimp_signup_form($form, &$form_state, MailchimpSignup $signup) {
   +    '#title' => 'Update Message',
   

   This and several other strings should be localized.

2. +++ b/modules/mailchimp_signup/mailchimp_signup.module
   @@ -365,11 +365,13 @@ function mailchimp_signup_subscribe_form_submit($form, &$form_state) {
   +    $result = mailchimp_subscribe($list_id, $email, $mergevars, $signup->settings['doublein'], $signup->settings['send_welcome'], 'html', TRUE, !$signup->settings['preserve_interest_groups']);
   

   The last argument added here could use an explanatory comment. Why does it use the ! operator?

3. +++ b/modules/mailchimp_signup/mailchimp_signup.module
   @@ -381,9 +383,12 @@ function mailchimp_signup_subscribe_form_submit($form, &$form_state) {
   +  if (count($successes) && isset($signup->settings['confirmation_message']) && strlen($signup->settings['confirmation_message']) && empty($member)) {
   

   Could use a code comment. What's going on here?

4. +++ b/modules/mailchimp_signup/mailchimp_signup.module
   @@ -381,9 +383,12 @@ function mailchimp_signup_subscribe_form_submit($form, &$form_state) {
   +    drupal_set_message($signup->settings['update_message'], 'status');
   

   Does this need check_plain()?

@nedjo, not sure I can clarify the comment I made 4 years ago, but we're happy to revisit this and see if it still makes sense and can be cleanly applied. Thanks, as always, for your community stewardship.

@pmchristensen, do you want to revisit your patch per @nedjo's comments? The patch is also mixing issues as the matter of overwritten interest groups is not ties to the addition of an update message.

Retitling this issue to make the difference with #2510640: Existing subscriber data overwritten when creating a new entity with a subscription field more clear.

added related issues

The latest patch here https://www.drupal.org/node/2510640 seems to fix the bulk of this issue. (https://www.drupal.org/files/issues/mailchimp-prevent-overwrite-on-entit...)

Anything beyond this seems like it would be a feature request.

In light of the progress made on the related issue above and the fact that the patch in #10 needs at least a reroll, I cannot commit this patch as is. If this feature is important for you, please consider posting a reroll and testing it.

We're going to be ending support for the 7.x-3.x branch due to the upcoming deprecation of the v2.0 MailChimp API. If you're still seeing this issue with the most recent release, please feel free to reopen.