Am I mistaken, or isn't it project module that puts the version in the .info file during release packaging, meaning the version = VERSION in mail_logger.info should not be there already?

CommentFileSizeAuthor
#4 status report screenshot105.96 KBdeekayen
#3 mail_logger-info.patch689 bytesdeekayen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mokko’s picture

mokko CreditAttribution: mokko commented

I don't really know, but apparently you are right.

Be it as it may, in the dev version it is right and correctly says version = "6.x-1.x-dev"

If it works, I don't consider it a bug. Should we close it? Or remove the line with a patch?

litwol’s picture

litwol CreditAttribution: litwol commented
Status: Active » Fixed

If you check out source from CVS and a module uses 'version = VERSION' in it's info file then you will see in systems modules page something like 6.x-dev or equivalent. without it nothing will appear.

When packaging script on d.o creates a release it adds it's own version string with exact version number.

Either way this is not a bug neither a mistake.

deekayen’s picture

deekayen CreditAttribution: deekayen commented
Status: Fixed » Needs review
FileSize
mail_logger-info.patch689 bytes

You should be using http://drupal.org/project/cvs_deploy to show version numbers of CVS checkouts, not version = VERSION.

deekayen’s picture

deekayen CreditAttribution: deekayen commented
Title: version in .info file? » VERSION shouldn't be in .info file
Version: 6.x-1.0 » 6.x-1.x-dev
Category: support » bug
FileSize
status report screenshot105.96 KB

Just showing what happens when CVS Deploy is installed. The version in the .info file overrides CVS Deploy's feature to read the tag out of the CVS directory and reports a bogus version on the status screen with incorrect status.

deekayen’s picture

deekayen CreditAttribution: deekayen commented

I know I'm already in the pest category when I re-open an issue, but I really think what I've proposed here is the proper way to do versioning. If it also helps, the documentation on .info format officially discourages use of version in .info files unless your project is hosted off the d.o infrastructure.

sjpatrick’s picture

sjpatrick CreditAttribution: sjpatrick commented

I am also confounded by this module constantly and inaccurately reporting itself as unsupported.
As the suggested fix seems simple enough to implement, I fail to see why this is still an issue.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Reviewed & tested by the community

Looks good and confirmed.

deekayen’s picture

deekayen CreditAttribution: deekayen commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-6--1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.