Problem/Motivation

While going through the theme for issues I found out that the main menu is having '+' trigger button for the desktop. Also for the mobile menu sub menu items are already shown. And '+' trigger button do nothing.

Steps to reproduce

Install the theme
Add 5-10 menu links and create a submenu.
You will be able to see the trigger button '+' button on the desktop menu. Also, switch to mobile viewport you will notice trigger button is doing nothing also the sub menu is open. I am attaching screen recordings for better understanding.

Proposed resolution

Fix the Ui as well as the JS part and make menus work better and as expected.

Remaining tasks

none

User interface changes

Yes along with twig and js changes

API changes

none

Data model changes

none

Comments

Hamid.ali created an issue. See original summary.

hamid.ali’s picture

Adding patch in some time.

hamid.ali’s picture

Assigned: hamid.ali » Unassigned
Status: Active » Needs review
StatusFileSize
new41.42 KB
new10.55 MB
riddhi.addweb’s picture

StatusFileSize
new535.59 KB
new1.39 MB
new1.58 MB

The mentioned mobile menu & desktop navigation issue is resolved, & I have also checked and it is working as expected. Attaching the Screenshots & doing RTBC for the same.

Note:- There is one more issue, the Admin menu is overlapping the Hamburger menu in responsive devices, attaching the video for the same.

riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
orkutmuratyilmaz’s picture

Any chance for merge?

orkutmuratyilmaz’s picture

Version: 1.0.x-dev » 1.1.2
Status: Reviewed & tested by the community » Active