Problem/Motivation

We need to customize the config of the modules we add, but that's not easily possible with the config system. #3304540: Test config/install to provide config for used modules has resulted in a custom solution based upon config/optional folder.

Proposed resolution

Adopt https://www.drupal.org/project/config_rewrite and remove custom solution

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago created an issue. See original summary.

mbm80 made their first commit to this issue’s fork.

mbm80’s picture

Assigned: Unassigned » mbm80

mbm80’s picture

Assigned: mbm80 » Unassigned
Status: Active » Needs review

Enabled config_rewrite & removed rest_menu_items.config from install hook.
rest.resource.rest_menu_item cant be imported via config_rewrite as it is part of the rest_menu_items_test module, which is not enabled/required.

#nr

fago’s picture

Status: Needs review » Needs work

I commented the MR, please see the small remarks there.

I think the goal here should be to remove all the custom config-import code, if config_rewrite is not able to provide this, it seems to be not the full solution.
But - when rest.resource.rest_menu_item is not provided by a module, could we just put it into the regular install config? or optional config?

mbm80’s picture

Assigned: Unassigned » mbm80

checking

mbm80’s picture

Status: Needs work » Needs review

yes, rest.resource.rest_menu_item can be just default config #nr

  • fago committed f7a7da57 on 1.x authored by mbm80
    Issue #3340799 by mbm80: Adopt config_rewrite for install time config.
    
fago’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.