Drupal 8 Login Toboggan problems and cannot be uninstalled, how to to ?

I hope this patch solved this problem

I change in hook_uninstall method to get config
when used Drupal::config() - we gets data for only reading
should use \Drupal::configFactory()->getEditable() to change\remove config

I can confirm the patch solves the problem, thank you

This has been RTBC for a while. What is preventing the commit?

Patch works for me as well (could not create any new user anymore with LoginToboggan 8-dev installed).

Error message with Login Toboggan installed :
Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "user" entity type did not specify a "register" form class. in Drupal\Core\Entity\EntityTypeManager->getFormObject() (line 184 of /home/mywebsite/public_html/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

Without the patch I get the error:

Drupal\Core\Config\ImmutableConfigException: Can not delete immutable configuration [error]
logintoboggan.settings. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to
retrieve a mutable configuration object in
drupal-8.5.3/html/core/lib/Drupal/Core/Config/ImmutableConfig.php:51

Configurations do NOT need to be explicitly uninstalled. The whole hook_uninstall() for this module should be removed, as there is nothing that needs to be done here in Drupal 8.

Note that the configuration .yml file is in the wrong place and lacks a schema, so if it's not automatically uninstalled that's the reason.

TR is correct. There is no need to explicitly delete the config. The permission page problem was caused by an obsolete method for calling config. That's already fixed. For this one I'm moving the uninstall, and removing the config delete.