I don't want to delete unverified users, I just want to block them. It would be nice if this was an option in logintoboggan.

I will work on a patch.

CommentFileSizeAuthor
#9 logintoboggan--block-users-instead-of-deletion.patch7.86 KBorganicwire
#8 logintoboggan--block-users-instead-of-deletion.patch7.63 KBorganicwire
#7 logintoboggan--block-users-instead-of-deletion.patch6.54 KBorganicwire
#2 logintoboggan--block-users-instead-of-deletion.patch5.6 KBorganicwire
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pjcdawkins created an issue. See original summary.

organicwire’s picture

organicwire CreditAttribution: organicwire as a volunteer and commented
Status: Active » Needs review
FileSize
logintoboggan--block-users-instead-of-deletion.patch5.6 KB

Here's a patch for the desired functionality. Note that for security reasons, the default changed from delete users to block users. That's a more conservative setting that prevents losing data (such as when users already created content).

In admin/config/system/logintoboggan a few things changed:
- new setting Disable operation
- renamed Purge unvalidated users after into Disable unvalidated users after
- moved all related items into their own field group

pjcdawkins’s picture

pjcdawkins CreditAttribution: pjcdawkins as a volunteer commented
Assigned: pjcdawkins » Unassigned
Status: Needs review » Needs work

Thanks for the patch! I've reviewed by eye.

The patch introduces the words "disable" and "discard" (as well as the Drupal core terminology, "block") which I think add unnecessary extra meaning. I think the word "purge" could still be used to mean either blocking or deleting: I'd recommend using that. It would then be the same word in the UI and in the code (it would match logintoboggan_purge_operation).

gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and commented
Status: Needs work » Needs review

@pjcdawkins The patch addresses a critical issue of this module (which you yourself reported) and is working perfectly for me. The proposed terminology makes it clear what happens with unauthenticated users and seems sensible. If you disagree with the terminology, please do not block the patch by tagging it 'needs work'. Instead, please upload a patch yourself (and an interdiff if possible) so we can quickly go on with getting it commited.

To me #2 is RTBC.

organicwire’s picture

organicwire CreditAttribution: organicwire as a volunteer and commented

@pjcdawkins says:

The patch introduces the words "disable" and "discard" (as well as the Drupal core terminology, "block") which I think add unnecessary extra meaning. I think the word "purge" could still be used to mean either blocking or deleting: I'd recommend using that.

Thanks for your review. I agree that somehow an extra meaning is introduced. However, I think that it's needed. The term "purge" very much sounds like deletion. So I propose to use the term "Disable" that distinctively means blocking users and not deleting them.

If there's any native english speaker around with better suggestions, I'm happy to see your patches!

organicwire’s picture

organicwire CreditAttribution: organicwire as a volunteer and commented

Hi @pjcdawkins, do you have any suggestions? I'll be happy to see another patch.

organicwire’s picture

organicwire CreditAttribution: organicwire as a volunteer and commented
FileSize
logintoboggan--block-users-instead-of-deletion.patch6.54 KB

Added a fix: When blocking users you want unpublish their content. This is included in the new patch. Before their content was left untouched.

organicwire’s picture

organicwire CreditAttribution: organicwire as a volunteer and commented
FileSize
logintoboggan--block-users-instead-of-deletion.patch7.63 KB

Include new variable in contrib/logintoboggan_variable/

organicwire’s picture

organicwire CreditAttribution: organicwire as a volunteer and commented
FileSize
logintoboggan--block-users-instead-of-deletion.patch7.86 KB

Patch #8 breaks cron run when no unvalidated users exist. The new patch fixes this. Applies on 7.x-1.5