As a follow up to the Content Access issue: #915170: Conflict with LoginToboggan Module

Content Access attempts to optimize node grants where possible, but runs into problems when the 'Non-authenticated role' LoginToboggan option is used. If a content type has view permissions granted to the Authenticated and Non-authenticated roles it will erroneously optimize away the Non-authenticated role, since it treats the Authenticated role as a superset of all other user-defined roles.

The mentioned issue contains a patch for LoginToboggan to implement a hook which specifies to Content Access that the Non-authenticated role, if defined, requires special treatment.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hunmonk’s picture

Status: Needs review » Needs work

i'm very resistant to adding module-specific code to LT, and as such i won't commit the patch listed at #915170: Conflict with LoginToboggan Module. it would be trivial for somebody to roll an 'LT/Content Access Compatibility' module if they wanted. if that does happen, i would consider placing that in the wild west 'contrib' folder of LT, but would not actively maintain it.

good_man’s picture

subscribe

gapple’s picture

Status: Needs work » Needs review
FileSize
3.99 KB

Here's my compatibility module. The module itself is trivial, but I've added some code to a hook_enable implementation to warn of potential configuration issues, and prompt for a node access rebuild if needed.

hunmonk’s picture

Title: Non-authenticated role requires special treatment in Content Access » Content Access compatibility contrib module
Status: Needs review » Fixed

committed to 7.x-1.x. i did not test the module at all, the contrib folder is the wild west, so hopefully it works. ;)

gapple’s picture

Status: Fixed » Needs review

The provided patch was made for the 6.x branch; I will have to update and test a patch to update it for 7.x.

hunmonk’s picture

ah, whoops. well, i pushed the code to the 6.x branch as well just now, so that fixes that problem. if you could provide a patch against the 7.x version i'll commit it, or just let me know that it works as is. hoping to roll another 7.x release soon, so it would be great if you could get back to me soonish. :)

gapple’s picture

It doesn't appear that there are any changes between 6.x and 7.x in either module that will affect this functionality, so the only change that should be required is bumping the core version in logintoboggan_content_access_integration.info to 7.x

I've attached patches for both 6.x and 7.x versions which add a short README file, and the 7.x patch also changes the .info core version

hunmonk’s picture

Status: Needs review » Fixed

committed the patches to their respective branches. thanks for the turnaround time, it's always nice when somebody shows up in the issue queue with patches!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.