Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | login_tracker-d11-3431749-24--for-2.0.0.patch | 756 bytes | jedihe |
| #23 | login_tracker-d11-3431749-23.patch | 802 bytes | jedihe |
| #2 | login_tracker.2.0.0.rector.patch | 329 bytes | project update bot |
Issue fork login_tracker-3431749
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #6
leewillis77 commentedNo plans to support Drupal 11.
Comment #7
hexabinaerYou are kidding, right?
That would mean you are planning to let the module die for currently 763 sites.
Comment #8
leewillis77 commented@hexabinaer Are you offering to fund my time to port & support it on Drupal 11?
In absence of that, I do not have the time to carry out the work, or to verify suitable stewardship* for the project going forward.The project is open source, so anyone willing to maintain it is empowered to fork it and release it with Drupal 11 compatibility.
*Simply signing it over to an unvetted maintainer would be a potential security issue for those 700+ active sites and is (in my opinion) a much worse option than deprecating it.
Comment #9
bramdriesenHi @leewillis77
Just going to jump in here. As the upgrade bot is stating, just merging this patch/MR would make the module compatible with D11. That would take no more as 5 minutes, so in the time you've written those two comments, you could have probably merged it and tagged a new release 😉.
Note that no one in this issue is asking for co-maintainership, the issue you are referring (which you closed) was indeed a bit... far fetched to be granted. But that should not hold back any other contributions being made to this module.
Forking a module just to change the info.yml seems a bit excessive to say the least. So at least, let's keep this issue open so people needing it can use Drupal Rector to facilitate the patch from this issue to proceed with their upgrade path to Drupal 11.
Comment #10
leewillis77 commentedThat's a big assumption. I have *no* idea of whether that is true or not, however in order to be a responsible maintainer I would have to spin up a Drupal site, and test in order to be happy to release. I don't track Drupal core development and I have no idea whether or not other changes would be required and I'm not willing to just push a release based on automated fixes without testing that it works myself.
I am not willing to spend the time reviewing, testing and being responsible for contributions to this module. I no longer work with Drupal day-to-day and my open-source time contributions are focussed elsewhere. In the absence of that, contributions to this will not be accepted, beyond my existing commitments to support it on Drupal ^8.9 || ^9 || ^10 - hence the closure of this issue.
That would set an expectation that the module is supported on Drupal 11, which it is not.
Comment #11
bramdriesenNot really, that's how the past upgrade bot issues have tackled many module upgrades. It helps with deprecations and core changes for example. It does not actually test the module, but code wise it does verify any issues between major versions of Drupal.
Please explain how an compatibility issue for D11 that is not merged, has the status needs work or needs review would make it look the module is compatible? It would only be compatible if there is a tagger release with D11 support.
Please just leave this open as the bot would also fix future incompatibilities if there are any to be added. Closing this won't help the module nor the community in finding this.
Well that basically means you are abandoning the module, and thus you might want to have a read at this: https://www.drupal.org/node/2332703 Other people might try to apply for co-maintainership then through https://www.drupal.org/project/projectownership. Since you're not willing to maintain it, you should create a new issue in this queue that you are looking for new co-maintainers and see if someone who is more experienced with the module steps up to take up that role.
Sure, that's your call to make. But please just leave this open, like all contrib modules do...
Comment #12
leewillis77 commentedIt sets an expectation that the changes will be merged at some point. They won't.
I am not offering a version at Drupal 11 or above. As I said previously in this thread I do not have the time to vet co-maintainers, and transferring ownership to an unvetted new owner would be a significant security risk.
Comment #13
bramdriesenAbandoning means anyone could become co-maintainer without your intervention. They will be vetted by the projectownership team (Drupal.org site moderators). Leaving an issue open does not implicate it will ever be merged (by you as you have clearly made that point). I don't understand why you keep closing it, just leave it open so others can find it and test it and if any issues arise, fix them here. If you merge them or not I don't care. But leaving this open invites other people to contribute. Even if you've set the status that the module is no longer maintained (by you).
Also you can have other people do the vetting, you don't have to bother with that if you don't want to.
Comment #14
leewillis77 commentedI haven't seen any documentation that clearly states that that is a valid process. The document you linked to puts the onus on me to find and vet a suitable replacement. Perhaps https://www.drupal.org/node/2332703 needs to be clearer if that is an option.
Because I don't have the bandwidth to deal with it. My closing the issue doesn't stop someone taking the existing code and fixing up any issues if they want to, and it doesn't stop them releasing a D11 version of the module.
If there's a defined process for that happy to hear about it.
Comment #15
bramdriesenThis is the process: https://www.drupal.org/node/2332703#s-strategies-for-finding-new-maintai...
Or in your case: https://www.drupal.org/node/2332703#s-giving-up-a-project
Usually other maintainers vet for each other over there in that issue queue.
That would mean forking, which is by my understanding, a discouraged process for Drupal Contrib. Hence why there are project transfership processes and processes to become a co-maintainer if a module is no longer maintained or the user is no longer around.
Comment #16
leewillis77 commentedThat still reads as though the onus would be on me (to manage an issue in this project's queue, and another in the Project Ownership project queue), and (more importantly) doesn't state anywhere how any such new owners would be vetted and whether I would need to invest time in the process. If there was a clear process for this I would follow it, but there's not and I've already spent *far* too much time debating this already.
I will be supporting this module until D10 goes end of life. I will not be accepting patches for D11 compatibility. I will not be releasing, or supporting a D11 version. This issue will remain as "Closed (won't fix)".
Comment #17
cmlaraAs a security engineer I agree with @leewillis77 assessment.
Announcing you will not continue developing and allowing users a chance to find an alternative is basic secure maintainer ethics.
Won’t fix is a standard method to signal a patch will not be merged.
Despite how D.O. attempts to downplay it owners are indeed (ethically) responsible for any maintainers they add to a project.
The XZ back door last year is an example of a security incident that nearly compromised a major portion of the Linux community, the cause, overworked project owner adding a developer they could not properly validate and supervise.
@leewillis77 FYI this is originating out of
#3502566: Offering to co-maintain. The user came onto Slack seeking assistance to bypass your refusal to add them. @bramdriesen likely isn’t advocating for that user (we have an open abuse issue for TATA employees) however is expecting that some day the module will eventually be D11 compatible.
More details in #3500259: Employees of TATA Consultancy Services are bulk posting requests to gain (co-)maintainer access to modules.
While I agree with how you are handling this I do want to mention there is a good chance D.O. Staff will eventually override you either through site ownership queue or the Project Update Working Group and force either a D11 fix or a new maintainer into the project, messages like offering to become a maintainer are a step one in that forceful takeover process.
@bramdriesen: there is an open issue encouraging D.O. to adopt the fork positive workflow: #3452328: Prohibit the ability to adopt a project. Never let a Drupalism stand in the way of better security. Just because it is how it has always been done does not mean it is a secure process. As a future Full DST member it is your responsibility to always argue for the more secure software development path not the easiest.
Comment #18
leewillis77 commented@cmlara This is indeed, exactly my point (explained far more eloquently than I managed) and I can't see that any existing mechanisms mitigate that issue, hence my chosen course of action.
To clarify, I have no issue with the project being passed on to a properly vetted user. I just don't have the time / resources to ascertain who that might be.
Comment #19
bramdriesenOh yes, don't get me wrong here :-) I'm all ears and eyes for a more secure process around the whole project maintainership. I just stated what is currently in place and that someone else in fact can become maintainer without intervention of Lee. Hence why I also created https://www.drupal.org/project/securitydrupalorg/issues/3500263 as a result of the bulk maintainer requests of TATA.
The issue title: #3452328: Prohibit the ability to adopt a project does not sound like a thread to adopt forking. So that might need some work as well if that's the intent (didn't read the whole thread yet).
Comment #23
jedihe commentedApologies for the noise, just wanted to fix a fatal on D11 (login flow).
Attached patch from current work in MR!5.
Comment #24
jedihe commentedSame patch as #23, but re-rolled so it applies correctly on top of 2.0.0.