Problem/Motivation

Add dedicated "Administer Login Security" permission

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork login_security-3581476

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
aayushpathak’s picture

aayushpathak commented

working ...

aayushpathak opened merge request !34

aayushpathak’s picture

aayushpathak commented
Status: Active » Needs review

I have implemented the Administer Login Security permission and assigned it to the route. Kindly review and verify.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks @aayushpathak. LGTM, but this please needs an update hook to grant the new permission to anyone who had the old permission before to not cause regressions.

You should find the code in other modules that introduced similar permissions later.

aayushpathak’s picture

aayushpathak commented
Status: Needs work » Needs review

Thanks for the feedback!
Added update hook (login_security_update_9001) to grant the new permission to existing roles and prevent regressions. Kindly review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks @aayushpathak - update hook looks good, but code style is broken.
Maybe you could take a look at #3471594: Fix the issues reported by PHP_CodeSniffer afterwards to get CI green?