Problem/Motivation
Hard blocking implemented by this module seems to be very similar to what Drupal Core 8+ does with its flood service.
I guess that when this module was developed for Drupal 7, that didn't exist.
See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Flood%21F...
So we should discuss how to better integrate with Core's flood functionality and extend it with this modules helpful functionality like notifications, settings, etc. for hard blocking.
Edit: I just saw, that the module already has a dependency on drupal:ban module, so perhaps parts of this already use the core flood functionality. This has to be researched.
Steps to reproduce
Set a login_security limit that's lower than the one from Core Flood and see that not
Proposed resolution
- Find and write down differences here
- Make a plan for integration and discuss it
- Implement
- Test
- Release
That may for example include:
- Remove duplicate functionality from this module and instead refer to flood_control for settings and unblocking
- If possible, extend the core flood functionality
- Ensure that additional functionality like messages, soft-blocking and other features are preserved
Comments
Comment #2
anybodyComment #3
anybodyComment #4
anybodyJust found this duplicate: #2956153: Use the Core Flood Service instead of modules custom implementations
Comment #5
anybodySo I'm closing this as duplicate. I moved over large parts of the issue summary.