Problem/Motivation

Hard blocking implemented by this module seems to be very similar to what Drupal Core 8+ does with its flood service.

I guess that when this module was developed for Drupal 7, that didn't exist.
See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Flood%21F...

So we should discuss how to better integrate with Core's flood functionality and extend it with this modules helpful functionality like notifications, settings, etc. for hard blocking.

Edit: I just saw, that the module already has a dependency on drupal:ban module, so perhaps parts of this already use the core flood functionality. This has to be researched.

Steps to reproduce

Set a login_security limit that's lower than the one from Core Flood and see that not

Proposed resolution

  1. Find and write down differences here
  2. Make a plan for integration and discuss it
  3. Implement
  4. Test
  5. Release

That may for example include:

  • Remove duplicate functionality from this module and instead refer to flood_control for settings and unblocking
  • If possible, extend the core flood functionality
  • Ensure that additional functionality like messages, soft-blocking and other features are preserved

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Anybody created an issue. See original summary.

anybody’s picture

Issue summary: View changes
anybody’s picture

Issue summary: View changes
anybody’s picture

Title: Use Core Flood for hard blocking users? » Use Core Flood Service for hard blocking users?
anybody’s picture

Status: Active » Closed (duplicate)

So I'm closing this as duplicate. I moved over large parts of the issue summary.