Problem/Motivation

The help page for this module is currently broken and refers to a README.txt from an old 6.x branch.

User warning: Invalid placeholder (!README) with string:[...]

Steps to reproduce

Proposed resolution

Use a smart help hook which displays the current README on the help page.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#31 3327553-31--2.x.patch2.13 KBsoothmidas
#31 3327553-31--2.0.3.patch2.13 KBsoothmidas
#7 patch-applied.png13.45 KBanoopsingh92
#4 3327553-4.patch1003 bytesnoorulshameera

Issue fork login_security-3327553

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

grevil’s picture

grevil commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @Grevil, confirming this. Should be fixed.

noorulshameera’s picture

noorulshameera commented
Status: Active » Needs review
StatusFileSize
new 3327553-4.patch1003 bytes

Adding a patch to fix the deprecated link on help page.

anoopsingh92 made their first commit to this issue’s fork.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: Unassigned » anoopsingh92

Reviewing the patch. thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
StatusFileSize
new patch-applied.png13.45 KB

@noorulshameera patch has been applied cleanly for me.
Patch #4
Thanks for the patch.

grevil’s picture

grevil commented
Status: Needs review » Needs work

@noorulshameera thanks for the patch, but I suggest not pointing to a static external Link, as this has to be updated for every major release. Furthermore, the README suffix should be changed to ".md" so markdown reader have an easier time styling accordingly.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Perhaps a magic link like this could be used?

https://git.drupalcode.org/project/login_security/-/blob/@/README.txt

Please rewrite the README.txt to README.md in a separate issue @noorulshameera thanks :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Please prepare the changes as MR, not as patch. The MR is currently empty?!

Arturo1007 made their first commit to this issue’s fork.

Arturo1007 opened merge request !14

Arturo-q’s picture

Arturo-q commented
Status: Needs work » Needs review

Hi, I've created the MR using the patch, I also added the link suggested on #9.

grevil’s picture

grevil commented
Status: Needs review » Needs work

The README is still a .txt file!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review

Fixed that!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented

Thanks @Anybody, for the changes, I didn't know you also working on that. At the same time, we are working on the same ticket. You have pushed just a few minutes ago. When I got the conflicts in the same files then I accept incoming changes.
Thank you so much.

grevil’s picture

grevil commented
Status: Needs review » Needs work

Final thing, please remove the "--------------" in the .md file.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Status: Needs work » Needs review

Hello @Grevil, I have removed "--------------" from the headings from the .md file. Please verify.
Thanks

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

I still see a merge error and the MR can not be merged? Has to be rebased locally.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Status: Needs work » Needs review

Given the above, for review?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

https://git.drupalcode.org/project/login_security/-/merge_requests/14

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@anoopsingh92 @Arturo1007 could you rebase this MR?

anoopsingh92 opened merge request !19

anoopsingh92 closed merge request !19

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented

I tried to fix that MR issue with the new branch also but did not get success. That's why I have closed the merge request !19.

I am still getting the below message. 

Merge blocked: fast-forward merge is not possible. To merge this request, first rebase locally.
The source branch is 9 commits behind the target branch
1 commit will be added to 2.x.
Source branch will not be deleted.

MR is not mergeable. Anyone can try to fix that MR blocker.

Thank you

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented

I think we can close this MR and then we can recreate a new MR and apply the changes.
Then we can push the changes into the new branch or the same branch.

grevil’s picture

grevil commented

Creating a new MR on the same branch won't fix the issue. As stated a rebase is needed.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
Category: Task » Bug report

Hi I will try to a do a rebase

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi a did the rebase please revise.

soothmidas’s picture

soothmidas commented
StatusFileSize
new 3327553-31--2.0.3.patch2.13 KB
new 3327553-31--2.x.patch2.13 KB

I discovered this issue in the 2.0.3 release running Drupal 11. I fixed it in my site by printing the contents of the README file in the help file and abandoning a link all together. I also change the README from a txt to a md file. I have provided patches for the 2.0.3 tag as well as the 2.x branch (See filename).

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Please do NOT use patches, but the MR.