Currently, the notification threshold is attempted to be stored in config (fatal errors occur, since the config isn't editable). Rather than fix the config to be editable, it makes more sense to move this to the new State API.

Patch forthcoming.

CommentFileSizeAuthor
#1 use-drupal-state-2449851-01.patch10.8 KBjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Active » Needs review
FileSize
use-drupal-state-2449851-01.patch10.8 KB

This patch includes a new test for notification threshold. In addition to switching to use the State API, it does the following:

  • Removes login_security_t() function in favor of String::format()
  • Fixes an issue wherin user_logout() was called when there was no user logged in (which triggered a PHP notice)

  • jribeiro committed 4a0114a on 8.x-1.x authored by jhedstrom 
    Issue #2449851 by jhedstrom: Use State API instead of config for...
jribeiro’s picture

jribeiro CreditAttribution: jribeiro commented
Status: Needs review » Fixed

Thanks again @jhedstrom.

Tested and approved.

Changes pushed to 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.