There is no configure link in the module, it would be helpful if we add that in the module

CommentFileSizeAuthor
#7 login redirect configure patch applied.PNG5.67 KBpankajsachdeva
#2 2880223-2.patch341 bytesPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Status: Active » Needs review
StatusFileSize
new 2880223-2.patch341 bytes

Applying the patch, please review

riddhi.addweb’s picture

riddhi.addweb commented

Thanks pavan for the patch, I checked your patch in simplytest.me and when i try to install the Login redirect module it shows me the below error.

Error :- "Fatal error: Call to undefined function url() in /home/rco2v/www/sites/default/modules/login_redirect/login_redirect.install on line 15"

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
pankajsachdeva’s picture

pankajsachdeva commented
Assigned: Unassigned » pankajsachdeva
pankajsachdeva’s picture

pankajsachdeva commented

Hi Jigar,

This error message "Error :- "Fatal error: Call to undefined function url() in /home/rco2v/www/sites/default/modules/login_redirect/login_redirect.install on line 15" not because of this configure link patch.

This is because url() function is deprecated in Drupal 8. Now we have to use 'Drupal:url()' instead.

I am creating a new issue for this https://www.drupal.org/node/2881695.

pankajsachdeva’s picture

pankajsachdeva commented
StatusFileSize
new login redirect configure patch applied.PNG5.67 KB

Hi Pavan,

I have manually reviewed your patch and also applied successfully. Patch is looking good.

Nice work!!!

+1 RTBC

pankajsachdeva’s picture

pankajsachdeva commented
Assigned: pankajsachdeva » Unassigned
Status: Needs work » Reviewed & tested by the community