Hi!

Just a few coding standards improvements.

I hope to help.

Thanks.

CommentFileSizeAuthor
#2 coding_standards-2888210-2.patch16.89 KBgmaltoni
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gmaltoni created an issue. See original summary.

gmaltoni’s picture

gmaltoni CreditAttribution: gmaltoni at CI&T commented
Assigned: gmaltoni » Unassigned
FileSize
coding_standards-2888210-2.patch16.89 KB
Algarte’s picture

Algarte CreditAttribution: Algarte at CI&T commented
Status: Needs review » Reviewed & tested by the community

I've applied the patch #2 on a clean drupal environment and it is working fine for me.

I've also ran coder and didn't found any coder issue.

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented
Status: Reviewed & tested by the community » Needs review

Hi Algarte,
Getting error while applying patch. can you please review again? Below are the error occurring from my end.

$ git apply -v coding_standards-2888210-2.patch
coding_standards-2888210-2.patch:11: trailing whitespace.
Invoked when a user successfully uses a login_one_time link.
Checking patch README.txt...
warning: README.txt has type 100644, expected 100755
error: while searching for:
with this data.

hook_login_one_time_used($user)
Invoked when a user successfully uses a login_one_time link.
error: patch failed: README.txt:109
error: README.txt: patch does not apply
Checking patch login_one_time.install...
warning: login_one_time.install has type 100644, expected 100755
Checking patch login_one_time.module...
warning: login_one_time.module has type 100644, expected 100755
Checking patch login_one_time.rules.inc...