CI&T China team is upgrading this module in a hackathon event

CommentFileSizeAuthor
#9 updated_to_d8_from_7.x_2.x_dev-2693351-9.patch103.69 KBaloneblood
#8 updated_to_d8_from_7.x_2.x_dev-2693351-8.patch46.31 KBaloneblood
#6 updated_to_d8-2693351-5.patch46.36 KBjason-wang
#3 0001-Port-the-login-one-time-module-to-D8-version.patch103.52 KBjason-wang
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jason-wang created an issue. See original summary.

jason-wang’s picture

jason-wang CreditAttribution: jason-wang at CI&T commented
Title: Upgrade this module to d8 » Port this module to D8
jason-wang’s picture

jason-wang CreditAttribution: jason-wang at CI&T commented
FileSize
0001-Port-the-login-one-time-module-to-D8-version.patch103.52 KB

Uploading the patch, which started from a hackathon (co-worker: Jaguar, Michael Han, Steven Lin).

What have been done:

  1. Module was ported to D8
  2. Implementation change for the user search auto-complete, because Drupal 8 bring a field type "entity_autocomplete"
  3. Passed the Drupal code standard check via PAReview

What's the next steps:

  1. Currently the rule is not implemented, need to finish it
  2. Unit test need to be considered
  3. Other improvements or bugs fixes
Maedi’s picture

Maedi CreditAttribution: Maedi commented

Please keep going and when it's ready we will create a D8 branch.

jason-wang’s picture

jason-wang CreditAttribution: jason-wang at CI&T commented

Hi Maedi,

Here is the new patch with remaining tasks completed, which are:

  • Add support for rules
  • Fix minor issues/bugs

could you please take a review when you have time, and let me know if anything more need to be done from my side.

Thanks,
Jason

jason-wang’s picture

jason-wang CreditAttribution: jason-wang at CI&T commented
FileSize
updated_to_d8-2693351-5.patch46.36 KB

Sorry, forgot to upload the patch file, see attached "updated_to_d8-2693351-5.patch"

Nitebreed’s picture

Nitebreed
Primary language Dutch
CreditAttribution: Nitebreed at Synetic commented
Status: Active » Needs work

Patch does not apply on the latest 7.x-2.x-dev Also, I'm not seeing an info.yml file and I'm missing the required class?

aloneblood’s picture

aloneblood CreditAttribution: aloneblood at CI&T commented
FileSize
updated_to_d8_from_7.x_2.x_dev-2693351-8.patch46.31 KB

Hi. This patch is created on 7.x-2.x-dev.

aloneblood’s picture

aloneblood CreditAttribution: aloneblood at CI&T commented
FileSize
updated_to_d8_from_7.x_2.x_dev-2693351-9.patch103.69 KB

I'm sorry. The patch in #8 is error. I recreated a patch base on 7.x-2.x branch.

yechaozheng’s picture

yechaozheng CreditAttribution: yechaozheng as a volunteer and commented

Hi Maedi & Nitebreed,

Could you please help to check the new attached patch (#9) when you have time?
And please tell me what else you need if we want the D8 branch create.

Thanks,
Cato

yechaozheng’s picture

yechaozheng CreditAttribution: yechaozheng as a volunteer and commented
Status: Needs work » Needs review
bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Cybage Software Pvt Ltd. commented

Hi Maedi,
Patch does not apply with the 7.x-2.x branch at my end. Please try to Create an Dev branch and port this module at your end if it works.

After that we will try to release an alfa version after fixing all minor issues.

Thanks,

manuel.adan’s picture

manuel.adan
Location 🌌
CreditAttribution: manuel.adan commented

As an alternative, I can suggest implementing it using the email_confirmer module. I think most of the work will be completed with it and it would be easy to port this module to D8. If interested, I can help.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
CreditAttribution: levmyshkin at CimpleO commented

Drupal 8 module created by #9 patch:
https://github.com/levmyshkin/drupal-8-login-one-time

glass.dimly’s picture

glass.dimly CreditAttribution: glass.dimly commented

This github module should be released as an alpha branch, unless there are security issues in it, so that others can contribute.

bapi_22’s picture

bapi_22 CreditAttribution: bapi_22 at Globant commented

Hi levmyshkin,
Can you please verify one more time if login one time button is visible on user account's page.

Then we can go for an alfa release.

Thanks

DuneBL’s picture

DuneBL
Primary language French
CreditAttribution: DuneBL commented

@bapi_22, I have made a pull-request on the levmyshkin master branch with some fixes.
Whith those fixes, I confirm the button is displayed in the user account's page

For those who can't wait, here is the fixed branch I am talking about: https://github.com/dunebaud/drupal-8-login-one-time/tree/make-it-work

DuneBL’s picture

DuneBL
Primary language French
CreditAttribution: DuneBL commented

@bapi_22 my PR has been accepted (so quick)
So please use: https://github.com/levmyshkin/drupal-8-login-one-time (As I have deleted my branch)
If you think it is a good idea, it can be pushed to drupal.ord

DuneBL’s picture

DuneBL
Primary language French
CreditAttribution: DuneBL commented

@levmyshkin Have added another PR on Github to fix the option "Ignore User Password"

Chvojan’s picture

Chvojan CreditAttribution: Chvojan commented

Hi, I'm trying use this module for Drupal 8. I can see a button at user account page. But the Action on user admin page is missing. I found "Send one-time login link to the selected users" in code and thats what I need. There is $options = login_one_time_path_options(); but this function is missing. Can you please help me. Am I doing something wrong?

JasonLuttrell’s picture

JasonLuttrell
Location Washington, DC area
CreditAttribution: JasonLuttrell commented

+1. This works great in D7, really need this for D8. Thanks!