Updated: Comment #0
Problem/Motivation
Long user agent strings (for example, some versions of IE8) result in a fatal PDOException and no record is written for the user even though they are in fact logged in. If error reporting is off then the user just sees "The website encountered an unexpected error. Please try again later.", otherwise they see that as well as the PDOException.
Proposed resolution
Truncate the user agent string if it's longer than 255 characters. According to this Stack Overflow post, user agent strings can push 8000 characters, so just increasing the limit doesn't seem like a good solution.
Remaining tasks
Patch needs review.
User interface changes
n/a
API changes
n/a
Related Issues
n/a
Comment | File | Size | Author |
---|---|---|---|
#1 | login_history-2110249-1.patch | 1022 bytes | star-szr |
Comments
Comment #1
star-szrPatch.
Comment #3
star-szrCommitted to 7.x, moving to 8.x.
Comment #4
star-szrCommitted to 8.x.