Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
in my login destinatin module I have setted to go at this path after login http://www.forniture-alberghiere.net/ dashboard/3
but when legal module is acting with a new agreement to accept, he force the redirect to the view of users area, in my case http://www.forniture-alberghiere.net/ users/estufe I hope that colaborating with author of http://drupal.org/project/legal module you can patch soon this simple but big problem.
Here direct link to contact him:
http://drupal.org/user/3555/contact
Comment | File | Size | Author |
---|---|---|---|
#5 | login_destination-legal-447480-5.patch | 888 bytes | rooby |
Comments
Comment #1
matteoraggi CreditAttribution: matteoraggi commentedIf someone find the same problem that I was having, you can find the patch of legal module here:
http://drupal.org/node/447476#comment-1539240
hoping that after version 6.x-2.2-beta4 this patch will be added to code.
Comment #2
rsvelko CreditAttribution: rsvelko commentedposponed
Comment #3
rsvelko CreditAttribution: rsvelko commentedComment #4
oskar_calvo CreditAttribution: oskar_calvo commentedwhat about this bug?
Oskar
Comment #5
rooby CreditAttribution: rooby commentedHere is a patch that fixes it for me in drupal 7.
Note that this won't port directly to drupal 6 as is because the hook_drupal_goto_alter() method of redirecting isn't used in drupal 6 (and can't be as the hook doesn't exist in drupal 6).
It might give someone direction on making a drupal 6 patch though (I haven't looked at the D6 code).
Comment #6
rooby CreditAttribution: rooby commentedBy the way, the drupal 7 symptoms are that the login destination redirect overrides the legal module's drupal_goto(), which means the user isn't sent to the legal page and they are logged out again silently.
Comment #7
mithy CreditAttribution: mithy commented@robby. Thank you for your continuous patches. However the root of this problem is a flawed way in which the Legal module handles logins and I will refrain from adding an error-prone hack in LD to fix it:
The problems in Legal module are:
Comment #8
mithy CreditAttribution: mithy commentedComment #9
rooby CreditAttribution: rooby commentedI see your point.
I'll have a look at doing a patch on the legal side of things. It definitely should be doing it's work in the validation stage.
On a side note, this is the first time I've seen the goto alter hook. It's a nice addition.
Comment #10
mithy CreditAttribution: mithy commentedDefinitely! Without this hook there is no way to do login destinations right. That's why it will never work for d6. This thread #761254: not working with content profile module ? has some explanations.
I posted about this bug in the queue of Legal module (#447476: conflict at login with login_destination module).
Comment #11
oskar_calvo CreditAttribution: oskar_calvo commentedI think that one of the module should build a hook and the other one check this hook or will not way to resolve this problem.
Oskar
Comment #12
mithy CreditAttribution: mithy commentedThe problem can be solved without a hook and this is really not a time for major changes in API.
Comment #13
amaisano CreditAttribution: amaisano commentedFYI the May 2017 Legal update 1.7 breaks the dirty hack/patch (that I was using). To fix, just adjust the if condition to this instead:
Basically the security update removes the arguments from the URL, so there is no trailing slash.
Still hoping one or the other modules implements a stable fix to this.
Comment #14
matman476 CreditAttribution: matman476 commented#5 combined with #13 works for me!
Comment #15
arne_hortell CreditAttribution: arne_hortell commentedAdd this to prevent issues with combination TFA//Legal//login_destination
if ($path && substr($path, 0, 10) == 'system/tfa') {
return;
}
Comment #16
rsvelko CreditAttribution: rsvelko commentedAdding exceptions for 'legal_accept', 'legal_accept/' and 'system/tfa'.
Comment #18
rsvelko CreditAttribution: rsvelko commented