Problem/Motivation

When running PHPCS as per https://www.drupal.org/docs/contributed-modules/code-review-module/php-c..., there are a few warnings shown which should be resolved.

Steps to reproduce

Run PHPCS on the module codebase.

Proposed resolution

Fix all the errors and warnings.

CommentFileSizeAuthor
#4 phpcs_errors_login_destination_before.txt2.87 KBandregp
#3 phpcs_errors_login_destination.txt3.81 KBandregp
#3 phpcs_errors_login_destination_after.txt4.44 KBandregp
#2 3257760-2.patch3.85 KBgaurav.kapoor

Comments

gaurav.kapoor created an issue. See original summary.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Active » Needs review
StatusFileSize
new 3257760-2.patch3.85 KB
andregp’s picture

andregp commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new phpcs_errors_login_destination_after.txt4.44 KB
new phpcs_errors_login_destination.txt3.81 KB

Patch applies correctly and solve all issues. You can check on the files attached the PHPCS errors before the patch and after (I run with verbose modifies so you can see there are 0 errors/warnings on each file).

Thanks @gaurav.kapoor

andregp’s picture

andregp commented
StatusFileSize
new phpcs_errors_login_destination_before.txt2.87 KB

Sorry, I sent one of the files wrong. Here is correct one.

andregp’s picture

andregp commented

  • rsvelko committed 465a9aa on 8.x-2.x 
    Issue #3257760 by gaurav.kapoor, andregp: Resolve warning messages shown...
rsvelko’s picture

rsvelko commented
Status: Reviewed & tested by the community » Fixed

Thanks, all!

  • rsvelko committed d7ee4ef on 8.x-2.x 
    Issue #3257760 by gaurav.kapoor, andregp, rsvelko: Resolve warning...

  • rsvelko committed 4f152e9 on 8.x-2.x 
    Revert "Issue #3257760 by gaurav.kapoor, andregp, rsvelko: Resolve...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.