Problem/Motivation
LoginDestinationManager->findDestination() does not catch the InvalidArgumentException generated by getting aliasses for invalid paths.
I have had very similar experiences with other modules and Drupal core. Hoping that the maintainers here will take more of an interest in this issue ;)
Steps to reproduce
Have a setup where this module is active.
Login in via: https://domain.tld/user/login?current=nonexistingpagealias
You will receive a fatal error and WSOD instead of just logging in.
Proposed resolution
Catch the Exception and set path as empty.
There is no valid reason that we should further handle a non existing path.
Remaining tasks
Review and apply patch.
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
catch-path-alias-exception.patch | 767 bytes | weseze | |
Comments
Comment #2
weseze CreditAttribution: weseze commentedComment #3
gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant commentedComment #4
gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant commentedThe issue exists and the patch solves the problem.
Comment #6
gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant commented@rsvelko This can be marked fixed now. Thanks.
Comment #7
rsvelko CreditAttribution: rsvelko commented