Problem/Motivation

LoginDestinationManager->findDestination() does not catch the InvalidArgumentException generated by getting aliasses for invalid paths.
I have had very similar experiences with other modules and Drupal core. Hoping that the maintainers here will take more of an interest in this issue ;)

Steps to reproduce

Have a setup where this module is active.
Login in via: https://domain.tld/user/login?current=nonexistingpagealias
You will receive a fatal error and WSOD instead of just logging in.

Proposed resolution

Catch the Exception and set path as empty.
There is no valid reason that we should further handle a non existing path.

Remaining tasks

Review and apply patch.

User interface changes

None

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

weseze created an issue. See original summary.

gaurav.kapoor’s picture

Status: Active » Needs review
gaurav.kapoor’s picture

Status: Needs review » Reviewed & tested by the community

The issue exists and the patch solves the problem.

  • rsvelko committed 1412789 on 8.x-2.x authored by weseze
    Issue #3245047 by weseze: LoginDestinationManager->findDestination()...
gaurav.kapoor’s picture

@rsvelko This can be marked fixed now. Thanks.

rsvelko’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.