Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The LogForm at log/add/{log type} redirects to the default log view and displays a confirmation message after creating new logs: "Saved the %label log."
If a destination query param is provided when directed to the log form page it overrides the form's behavior of redirecting to the newly created log. This works as expected, but it would be nice to include a link to the log in the confirmation message so that it is easy to navigate back to the newly created log.
Steps to reproduce
N/A
Proposed resolution
Include a link to the log in the "Saved the %label log." confirmation message.
Remaining tasks
Implement change.
User interface changes
Add link to confirmation message.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3211985-10.patch | 568 bytes | m.stenta |
Issue fork log-3211985
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3211985-include-link-to
changes, plain diff MR !2
1 hidden branch
Comments
Comment #3
paul121 CreditAttribution: paul121 commentedComment #4
paul121 CreditAttribution: paul121 commentedThis always adds the link to the confirmation message. Maybe we should only add it if there is a
destinationquery param present? Is it confusing to be redirected to the log view page and have a link to the same page displayed above?Comment #5
m.stentaThanks @paul121 - this is a good addition. :-)
If it's alright with you, I might modify this slightly to:
Minor difference, but it puts the link at the end of the string, which feels slightly better. If that's OK with you I'll go ahead and amend your commit and merge this.
(Outside of the scope of this thread, but we should make this same change in farmOS for asset and plan entities for consistency.)
Comment #6
paul121 CreditAttribution: paul121 commentedYep that is a good improvement too!
Comment #8
m.stentaComment #9
m.stentaDoh! This caused a test to fail.
It says that your merge request passed tests - but I think something was up with our automated tests (see related: #3226354: Actions tests are failing) - maybe they weren't actually running as expected. Not entirely sure, but they appear to be working now - and hence this one is failing. I'll post a patch momentarily...
Comment #10
m.stentaPatch attached to update automated test.
Comment #12
m.stenta