Taxonomize Location CCK field

I think the support of Location CCK is very helpful. Actually, everythink works, only after saving the "location_taxonomize_location_submitt" is not executed, because the submit handler is not set.

Attached a patch for the support of Location CCK. A combination of Location Node and Location CCK should be possible (not tested).

At the moment it is assumed that the CCK field has the name 'field_locations'.

If other people are using this patch successfully, please post here to let me know, which will mean I will need to test less. Thanks.

cbeier, are you using this patch?

goron: Yes, also in production.

Patch seems mostly fine to me. The only problem is the hardcoded name for the field. Is there no way to detect whether there is a location cck field on the form (short of looping through all the form elements)? If not, could do one of the following:

1. Add UI in the admin form to select fields to taxonomize from a multiselect list populated with all fields of type location cck on the site. Try to access those on every node submit :-/
2. Implement hook_field_widget_WIDGET_TYPE_form_alter(), which, if called with location cck field type, adds a process function to the field which in turn makes a note in the form_state array that that field should be taxonomized. This is how location_taxonomize_af does it. This does add complexity to the module, but I think it's a cleaner solution than #1.

cbeier (and anyone else interested), if you have any time for this your thoughts and/or another patch would be welcome. I'm a bit swamped at the moment, so I don't know when I'll have time to implement this.

Some advance on this?

I tested the patch. It worked fine with Location CCK fields. It bulked all location cck to the newly created vocabulary as terms having a hierarchical term listing with Countries as parent terms and Cities as child terms.

I would recommend to create a new checkbox: " Location - Location CCK" in the Modules list. Currently there are "Location and Location - Address Field" so an extra box would clarify either you want to use for Location itself or Location CCK fields when you are going to active module.

Furthermore as commented in: #1541310: Get Location Taxonomize to work all entities, not just nodes it does not work nicely for Location CCK fields in Profile2 content type: Is true that I have the Hierarchical list of terms, but whatever I click on Countries or Cities it redirects to an empty page saying " There is currently no content classified with this term. "

So now we should all work to implement patches to work it for all entity types, specially Profile2 because I think there is the place most often used.

Thanks for great work.

I can confirm that the patch is working. Have to do some more extensive testing, but is looking good so far. Only problem is indeed the hardcoded fieldname, but that's not a big issue for me.

Thnx

I can confirm the patch is working and would really appreciate if support for taxonomizing the location cck field on node save would be moved into the next module update.

Only problem I face is that I set the address on a node through rules and also save the entity from rules. That does not trigger the location to be taxonomized. It only works when actually using the manual save action on the node itself. I think this should also work, I don't know if this would have worked without the patch, can't check.

Here's a slightly different approach. It will use the bulk function instead and works by checking for the linked location directly. This works with any type of module that saves location data and it unifies the way data is saved. This also means it will work with any field name.

I also tried using the entity/node insert and update hooks but this will cause an infinite loop because saving the taxonomy term also uses node_save. Maybe something for a different issue?

He klaasvw,

thank you for this patch. After i used your patch although i get 3 Notices (php Notice: Undefined property: stdClass::) but i fix it with if (isset(...)) quickly.

After this it works perfect with all location-cck-fields.

Great! Thank you very much - your Patch help me a lot.

Best Regards Matthias

Here i am using hook_field_widget_form_alter to get the location fields.
This patch also support multiple location fields in same node.

Let me know if you have any issues

Attached a updated patch for the support of Location CCK.

Thanks for the patch! It works great but unfortunately I get a fatal error when using multiple locations

Hi Quinten,

Kindly upload the error page screenshot, it will help to resolve the issue.

Thanks,
Balaji D

When im entering 2 locations I get this fatal error. It does not save it and jumps back to create the same node! And I get this also when I leave the location field empty. Futhermore I get 'Notice: Undefined index: #node_edit_form in location_taxonomize_form_alter() (line 35' when editing the location field.

Did some extra tests. And the following will give an error: when the location field is set to unlimited it gives the error but when it is changed to for example 2 values it works.

Ok Quinten, i will check and update you.

Thanks,
Balaji D

Hi Quinten,

The mentioned issue has been resolved, kindly apply this patch and verify.
Let me know if you have any concerns

Thanks,
Balaji D

Hi Balajidharma,

I can confirm that it works! Great work.

I only get this small notification when editing the location field:
Notice: Undefined index: #node_edit_form in location_taxonomize_form_alter() (line 36

Already before the latest patch. Nevertheless the functions are working perfectly!

The patch in #21 works for integration with both Address Field and Location, since you set 'field_locations' as machine name for your address/location field.