This issue is part of meta issue #1931088: [META] Fixing tests

Attached is a simple patch to load the zipcode data from the zipcode table if it exists.

I am currently building up the table with this data and will contribute another file shortly to populate the table with at least partial data for Mexico.

CommentFileSizeAuthor
#8 location-855898-8.patch1.54 KBc4rl
#1 855898_mexico_load.patch1.52 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Needs review
FileSize
855898_mexico_load.patch1.52 KB
YesCT’s picture

YesCT CreditAttribution: YesCT commented 
+++ location.mx.inc	(working copy)
@@ -37,3 +37,32 @@
+  $res = db_query("SELECT * FROM {zipcodes} where country = '%s' AND zip = '%s'", $location['country'], str_pad($location['postal_code'], 5, "0", STR_PAD_LEFT));

looks ok checking against http://drupal.org/node/101496

+++ location.mx.inc	(working copy)
@@ -37,3 +37,32 @@
\ No newline at end of file

but no newline at end of patch file.

Powered by Dreditor.

Still needs a functional review.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I basically copy/pasted this out of location.us.inc so if that code is working, this code will work.

I'm also using it and it works well for me ;)

jackbravo’s picture

jackbravo CreditAttribution: jackbravo commented
Status: Needs review » Reviewed & tested by the community

I'm using this code and works fine =).

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Reviewed & tested by the community » Postponed

postponed before tests fix
#1931088: [META] Fixing tests

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Postponed » Needs review

tests fixed #1931088: [META] Fixing tests
lets go

Status: Needs review » Needs work

The last submitted patch, 855898_mexico_load.patch, failed testing.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.

c4rl’s picture

c4rl CreditAttribution: c4rl commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
location-855898-8.patch1.54 KB

Re-roll

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Status: Needs review » Closed (outdated)

Closing old D6 issues as D6 is end of life