[master] Release of Location 6.x-3.1?

ankur is working really hard on getting a new release out. I'm not sure of a goal "date". But there is renewed effort in getting there. Please lend a hand by looking for any issues that "need review" and try out the patches and post a summary of your results. That will really help get there faster.

Its not official, but I cleaned up the issues and tried to mark the ones I thought the maintainers might consider critical for getting out a new release

http://drupal.org/project/issues/search/location?text=&assigned=&submitt...

#606342: Views Argument Handler for Proximity would be a good one that would be a good motivation for getting out a new official release. Along with the fact that many small bugs have been fixed in the last month. And, we have now, 3 maintainers making commits and I think another one coming back on board to look at big picture and d7 stuff.

I'm gonna make this a master issue, and hopefully with some feedback from the maintainers, we can focus our efforts in the right spots.

Yes, it's true. I'm eager to get something committed for an argument handler, particularly something along the lines of comment #36 in #606342: Views Argument Handler for Proximity

And, if we can, probably #718928: add options to set coordinates w/ user location, PHP code for field, filter

But the big one is #606342: Views Argument Handler for Proximity
I've been working on a patch, but free time is scarce. I'll see if I can get a revision of it uploaded to the issue thread, then perhaps folks might be able to take it from there. If not, I can work on revisions of the patch until I feel it's commit-worthy, but that might take longer.

If we can get that one in, I promise to put out a release and write a blog post documenting how to build a basic location/gmap module set-up. As I learned at the recent DrupalCon, one of the major gripes out there is that there is no straight-forward documentation on how to use the location module with the gmap module to create your basic plots of a node on a map, let alone things like proximity searches, etc.

The location/gmap module combination is certainly capable of it, but I can understand the complaint that how to make it happen is not obvious enough if you're new to the modules.

I'll revisit it and see if I can take what I initially posted, feedback and get it commit worthy for 3.x-dev. Thanks Cathy for the head up in this post.

ankur: This is excellent news! Much thanks to YesCT for her help on this.

Possibly my organization's website (www.urbanministry.org - see www.urbanministry.org/boston for an example of Location+Gmap) can unfork our copy of Location module in the new few months, although I don't think that some of our custom code would be module-worthy. I could try to abstract it enough to make it hook into the code, though, instead of changing the core Location code.

I'm incredibly busy with other work projects at the moment, but I'll try to review within the next few weeks, at least. We use proximity filtering with Views, so that would be great if a better version was in the module than the one I use, which is based on an old patch in the queue.

All:

YesCT has contacted me to bring my implementation of proximity searching to the table. I have an effective views proximity searching method with a hacked location handler. YesCT has seen my system and requested I write up a spec how I did it for consideration when desining the views argument handler.

I will write this tonight, but my immediate question is, should I post it here or in the general queue for the argument handler?

Please let me know and I'll have spec with the handler to the maintainers shortly.

Thanks!

Post it in an issue specific to the views handler... maybe one of these, or make a new one... issues are disorganized, I know. But lets keep this one just for updates on release stuff.

if #606342: Views Argument Handler for Proximity is not a perfect fit, try:

http://drupal.org/project/issues/search/location?text=&assigned=&submitt...

http://drupal.org/project/issues/search/location?text=&assigned=&submitt...

or try various other advanced searched in the issue queue for tags (they auto complete, so you can start typing "location vie" and see what comes up or "location proximit" too.

also there is a Location_views component for searching too.

I'd be happy to review any patches needed to keep this moving forward however I'm also flat out right now (I'm about to move to the other side of the world, it's a lot of work/stress :). Hopefully I'll be back in a couple of weeks to write some more patches and give the project maintainers a hand.

@evan23: I didn't realize there were other Evan's on d.o. Well met! :)

Hey,

Okay - it's up with the handler attached. http://drupal.org/node/606342#comment-2922394

YesCT you know my email and gchat - feel free to get at me if I can help in any way, I can give you access to the DB and such if you need it.

Thanks!

subscribing...

bdragon has given me the OK to create new releases of the gmap & location modules.

All the current RTBC issues have been committed.
I've put some time into looking at the distance/proximity issues over the last week and I will work some more on it in the next couple of days.

Then once those issues are tested and in we should be good to go.
The issues are the ones ankur mentioned in #4
#606342: Views Argument Handler for Proximity
#718928: add options to set coordinates w/ user location, PHP code for field, filter

I'll also try to get #821628: earth_longitude_range() in earth.inc uses invalid values with asin() done too as it would be good to get that one in.

A big Thank You! so exciting.

Frankly, I think you should put out a 3.1 release as is, even without the remaining issues being resolved, and then do a 3.2 release for those. There are so many problems with the 3.0 release that it is ridiculous, and no one has bothered to make a new release in a year and a half. For those of us relying on drush to maintain sites (a necessity since we have over 100), putting out stable releases (not just beta and release candidates) is critical. Drush won't get an unstable release unless you force it to.

@seanr:
I understand your frustration.
I have committed the patches that were able to be committed.
I'll give it a day or so in case any terrible bugs pop up from the latest commits and then do a new release.

6.x-3.1 is now available.
5.x-3.1 is not yet available due to some cvs access problems. I'm getting brandon to check it out.

I am trying to update my Drupal database from RC1 and getting this error each time:

An error occurred. http://www.bucyrusrotaryclub.com/bacf/login/update.php?id=55&op=do <br /> <b>Fatal error</b>: Call to undefined function views_get_all_views() in <b>/home/content/a/1/p/a1printinginc/html/bacf/login/sites/all/modules/location/location.install</b> on line <b>1133</b><br />

I had Views before but had since removed it. I'm guessing I need to uninstall and reinstall Location, and/or even reinstall Views and uninstall Views again..?

I uninstalled and reinstalled Location 6.x-3.1, and it is now fixed; thanks.

See #846862: Fatal error: Call to undefined function views_get_all_views() in location.install on line 1133 when updating to latest version if you are having the problem mentioned in #18, which occurs when you update without views installed.

wow! you did it. we did it. others did it. amazing.

my guess is that with an official release, we will get lots of people testing it .... so probably (a few?) new bugs to track down. :) The world goes around. :)

Everyone should celebrate the small goals accomplished!!!

Yeah, it's good to get it out :)
I was getting a little side-tracked by issues that didn't need to be addressed for this release.
As long as it stays in dev the majority of people will not be testing it so it's good to get it out and find the bugs and fix them as opposed to waiting even longer.

Thanks to everyone that has been helping test all the patches. It's a huge help.

I think I'll do a uniform comment for all the 3.0 / 3.1-rc1 issues along the lines of please test this in the new release (3.1) and confirm that it is still an issue, if not please close this issue (set status to postponed (maintainer needs more info)).
Then close the issues if there is no reply after a month.

That should clear a lot of issues out that just aren't relevant anymore.
And I'll do the same for gmap.

5.x-3.1 is available now.

rooby, I can do the issue cleaning (commenting about trying the new release) also.

Thanks, all your help in the issue queues is awesome.

The support requests for old versions have the potential to still be valid but bug reports for old versions are quite possibly already resolved in the new version.

Thanx Reuben for all your hard work!

Good to see this done ;-)