Improved location.pt.inc [#375084]

This issue is part of meta issue #1931088: [META] Fixing tests

Improved location.pt.inc.

Tested and working fine in drupal 6.9.

"Map links" support added to Portugal (did not exist before);
Whenever longitude and latitude are present use them directly ( "if (location_has_coordinates($location)) {" - taken from location.us.inc);
Updated the orthography for the "provinces" name (basically adding special "characters" such as "é", "ç" etc... not sure if this part is a good idea; you should know better).

Comment	File	Size	Author
#11	location-improved_location_pt_inc-375084-11.patch	3.15 KB	Jerenus
#11
#5	location.pt_.inc_.zip	817 bytes	hvalentim
#1	location.pt_.inc_utf8.zip	808 bytes	hvalentim
#2	location.pt_.inc_utf8_ok.zip	823 bytes	hvalentim
	location.pt_.inc_.zip	808 bytes	hvalentim

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hvalentim CreditAttribution: hvalentim commented 16 February 2009 at 12:17

File	Size
location.pt_.inc_utf8.zip	808 bytes

Concerning point 3, actually special characters work but you have to encode the file in UTF8 (something I was only able to test after manually cleaning the database provinces cache in Table: cache_location).

Comment #2

hvalentim CreditAttribution: hvalentim commented 16 February 2009 at 12:15

File	Size
location.pt_.inc_utf8_ok.zip	823 bytes

Seems you can not remove/update an attached file from a comment :)
Here it is "again" properly saved as UTF8 this time.

Comment #3

rbl CreditAttribution: rbl commented 22 February 2009 at 10:14

Hi HValentim!
Can't we ditch these 2 letter abbreviations for our districts? We don't use them so no one knows what they stand for. Google maps doesn't even recognize them if you include them in a search.
It would be much better to use the full district name, in the worst case scenario, transliterated to safe characters ex.: Évora > Evora; Brangança > Braganca, etc...

Ricardo

PS. thanks for the PT fix =)

Comment #4

YesCT CreditAttribution: YesCT commented 16 April 2009 at 07:58

Status:

Postponed (maintainer needs more info)

» Needs work

adding location.xx.inc string ... so people who are googling for related issues can find this one too.

I think if you want to get this committed, decide on a direction with the full district name, and re-roll it against the most recent version of dev.

Comment #5

hvalentim CreditAttribution: hvalentim commented 20 April 2009 at 10:09

File	Size
location.pt_.inc_.zip	817 bytes

I agree there is no point in using the abridged two letters code for the districts since no one uses/knows about them. In the attached version the names appear in full (so called Portuguese "special characters" included, since they work fine and, after all, are part of the "proper spelling").

I have tested it with Drupal 6.10 and Location 6.x-3.x-dev 2009-Apr-18 and found no problems. Hope this can be committed.