Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Checking and saving "Add another location from node view page" still displays checkbox as unchecked. Also, even when this is set correctly, the "Add location" form doesn't appear on node view.
Comment | File | Size | Author |
---|---|---|---|
#21 | location-add-another-location-1601170-21.patch | 5.5 KB | tommycox |
Comments
Comment #1
tommycox CreditAttribution: tommycox commentedThis patch fixes the checkbox not appropriately displaying as checked when saved as such. However it appears as if there's still no "add another" form generated on the node view page. That should be opened as a new issue if you're still seeking this functionality.
Comment #2
tommycox CreditAttribution: tommycox commentedInstead of creating a new issue I've revamped this patch to fix the feature completely; updated title and issue summary.
Cheers!
Comment #3
tommycox CreditAttribution: tommycox commentedChanged priority to critical since the issue renders location_addanother unusable and is without workaround
Comment #5
podarokWell, it is not critical. I agree that it is major, but it doesn't brake a site.
Comment #7
tommycox CreditAttribution: tommycox commentedRe-rolled patch from #2 with some additional commenting and code cleanup
Comment #8
tommycox CreditAttribution: tommycox commentedComment #14
tommycox CreditAttribution: tommycox commentedIt looks like the testbots are having some issues. Will probably have to wait for https://www.drupal.org/node/2375345 to clear up before re-testing
Comment #17
tommycox CreditAttribution: tommycox commentedComment #19
tommycox CreditAttribution: tommycox commentedThe tests for this patch are getting held up from a failed test on the Location module (https://qa.drupal.org/pifr/test/290218) due to #2375345: Dependency on core module results in PHP Fatal error: Cannot redeclare system_requirements(). Somehow those tests need to be rerun.
Comment #20
podarokadd fullstop please
fullstop
fullstop
fullstop again
fullstop
You have to add varible removing to hook_uninstall()
#7 needs work
Comment #21
tommycox CreditAttribution: tommycox commentedAdded fullstops and added variable removing to hook_uninstall()
Comment #22
tommycox CreditAttribution: tommycox commentedComment #23
podarok#21 commited
Thanks!