Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue is part of meta issue #1931088: [META] Fixing tests
Normally, the only two letter acronyms used for counties (i.e. Norwegian provinces) are two digit numbers (e.g. 19 for Finnmark county). This localization of the location module introduce an error when geocoding Norwegian addresses by inserting invalid two letter acronyms (e.g. ST for Sør-Trøndelag county). This is an unelegant fix, since it replace a string with itself, but atleast the errors are removed when geocoding Norwegian addresses.
Comment | File | Size | Author |
---|---|---|---|
#1 | location_no_inc.diff | 1.39 KB | trond7 |
location_no_inc.diff | 1.39 KB | maximiliam | |
Comments
Comment #1
trond7 CreditAttribution: trond7 commentedTank you.
This acronyms for Norwegian counties was bothering me too.
I see that you also put in the Norwegian letters.
The file also has a misspelling of one of the counties.
More og Romdal → Møre og Romdal → Møre og Romsdal
I attached en new version of your diff file with is error fixed.
Comment #2
hansfn CreditAttribution: hansfn commentedThe last patch from trond7 still has one typo - "Møre og Romdal" in the key for "Møre og Romsdal".
I'm changing the status to RTBC since we Norwegians agree.
If, and only if, it is unacceptable to replace the two-letter codes (that noone in Norway uses) to the full names, please fix the typo for "Sogn og Fjordane" - replace "SJ" with "SF".
Comment #3
podarokpostponed before tests fix
#1931088: [META] Fixing tests
Comment #4
podaroktests fixed #1931088: [META] Fixing tests
lets go
Comment #5.0
(not verified) CreditAttribution: commentedUpdated issue summary.
Comment #6
legolasboClosing old D6 issues as D6 is end of life