This issue is part of meta issue #1931088: [META] Fixing tests

Normally, the only two letter acronyms used for counties (i.e. Norwegian provinces) are two digit numbers (e.g. 19 for Finnmark county). This localization of the location module introduce an error when geocoding Norwegian addresses by inserting invalid two letter acronyms (e.g. ST for Sør-Trøndelag county). This is an unelegant fix, since it replace a string with itself, but atleast the errors are removed when geocoding Norwegian addresses.

CommentFileSizeAuthor
#1 location_no_inc.diff1.39 KBtrond7
location_no_inc.diff1.39 KBmaximiliam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

trond7’s picture

FileSize
1.39 KB

Tank you.

This acronyms for Norwegian counties was bothering me too.
I see that you also put in the Norwegian letters.

The file also has a misspelling of one of the counties.
More og Romdal → Møre og Romdal → Møre og Romsdal

I attached en new version of your diff file with is error fixed.

hansfn’s picture

Status: Active » Reviewed & tested by the community

The last patch from trond7 still has one typo - "Møre og Romdal" in the key for "Møre og Romsdal".

I'm changing the status to RTBC since we Norwegians agree.

If, and only if, it is unacceptable to replace the two-letter codes (that noone in Norway uses) to the full names, please fix the typo for "Sogn og Fjordane" - replace "SJ" with "SF".

podarok’s picture

Status: Reviewed & tested by the community » Postponed

postponed before tests fix
#1931088: [META] Fixing tests

podarok’s picture

Version: 6.x-3.1 » 6.x-3.x-dev
Status: Postponed » Needs review

tests fixed #1931088: [META] Fixing tests
lets go

Status: Needs review » Needs work

The last submitted patch, location_no_inc.diff, failed testing.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.

legolasbo’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)

Closing old D6 issues as D6 is end of life