This issue is part of meta issue #1931088: [META] Fixing tests

Notice: Undefined variable: criteria in location_cck_field_update() (line 214 of sites/all/modules/contrib/location/contrib/location_cck/location_cck.module).

I think that the absence of a variable due to the fact that it may only be declared in terms that might not be positive.

CommentFileSizeAuthor
#7 location-criteria_in_location_cck_field_update-1350452-7.patch959 bytesRaulMuroc
#1 IssueID_1350452_fix1.patch956 byteseuginewm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

euginewm’s picture

euginewm CreditAttribution: euginewm commented
Status: Active » Needs review
FileSize
IssueID_1350452_fix1.patch956 bytes

Notice: Undefined variable: criteria in location_cck_field_insert() line 184 of sites/all/modules/contrib/location/contrib/location_cck/location_cck.module

fix this issue in my patch

Denes.Szabo’s picture

Denes.Szabo CreditAttribution: Denes.Szabo commented
Status: Needs review » Reviewed & tested by the community

This patch solved our problem was the same before. Thx!

euginewm’s picture

euginewm CreditAttribution: euginewm commented

patch turned out useful

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Reviewed & tested by the community » Postponed

postponed before tests fix
#1931088: [META] Fixing tests

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Postponed » Needs review

#1931088-3: [META] Fixing tests mostly fixed for 7.x-3.x branch
this one needs review

Status: Needs review » Needs work

The last submitted patch, IssueID_1350452_fix1.patch, failed testing.

RaulMuroc’s picture

RaulMuroc CreditAttribution: RaulMuroc commented
FileSize
location-criteria_in_location_cck_field_update-1350452-7.patch959 bytes

Re-patched. Hope it passes test.

RaulMuroc’s picture

RaulMuroc CreditAttribution: RaulMuroc commented
Status: Needs work » Needs review
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Fixed

#7 commited pushed to 7.x-3.x
thanks!!

RaulMuroc’s picture

RaulMuroc CreditAttribution: RaulMuroc commented
Status: Fixed » Closed (fixed)

You're welcom :-)! Cool to hear things go on :-D!

RaulMuroc’s picture

RaulMuroc CreditAttribution: RaulMuroc commented
Issue summary: View changes

Updated issue summary.